Repository navigation
Docker risc0 v3 - #6
Conversation
Signed-off-by: Jun Kimura <junkxdev@gmail.com>
QA (CPU)Docker ImageRemote Attestation |
QA(GPU)HostOSUbuntu 24.04 KernelLinux 6.8.0-85-generic GPUSetupInstalling the NVIDIA Container ToolkitPrerequisitesBuild Docker ImageImportant In my environment, I needed to set Error(segment_limit_po2=20)run containercompose.yaml Enviornment Variablesexec RemoteAttestation(SIM)LCPbonsai-local |
|
|
||
| jobs: | ||
| build-and-push: | ||
| runs-on: ubuntu-22.04-16core |
There was a problem hiding this comment.
@toshihiko-okubo I just realized you are using the custom runner. Is it necessary to use a custom one for this job?
There was a problem hiding this comment.
The size of the cuda Docker image exceeds the disk size of the GitHub-hosted runner, so we must use a self-hosted runner.
There was a problem hiding this comment.
@toshihiko-okubo I understand, but you can use a more suitable runner from https://docs.github.com/en/actions/reference/runners/larger-runners .
There was a problem hiding this comment.
you can use a more suitable runner
Is it correct to understand that we should use the minimum spec necessary for execution?
When using the current large runner (4-core CPU), a Docker build without cache may take approximately 35 to 40 minutes. Specifying a lower specification may cause concerns about increased delivery times.
Since the large runner incurs costs based on workflow execution time, the current configuration strikes a good balance between cost and performance.
There was a problem hiding this comment.
@toshihiko-okubo I see, so you wish to increase not only the disk size but also the number of cpu cores. While I don't believe execution time is that critical for this task, it's fine for now.
| feature='${{ matrix.feature }}' | ||
|
|
||
| suffix="" | ||
| # If the profile is not `release`, append -${profile} |
There was a problem hiding this comment.
Are L53 and L58 comments required? I think these are obvious.
4cd5163 to
edd4ec5
Compare
f949484 to
40f8ef8
Compare
|
|
||
| ARG FEATURES="cuda" | ||
| ARG PROFILE="release" | ||
| ARG CARGO_RISCZERO_VERSION="3.0.3" |
There was a problem hiding this comment.
I believe the default values for these versions are unnecessary. The builder should give explicit versions.
|
|
||
| WORKDIR /app | ||
|
|
||
| ARG FEATURES="cuda" |
There was a problem hiding this comment.
The default feature should be either removed or "default".
a8bcf15 to
5ad846c
Compare
| - "release" | ||
| risczero_version: | ||
| - "3.0.3" | ||
| risczero_growth16_verifier: |
There was a problem hiding this comment.
s/growth16/groth16
Also, I prefer to use risczero_groth16_version same as risczero_version's format.
e97a15a to
9259789
Compare
|
@toshihiko-okubo before merging this, can you squash the commits into a single commit? |
9259789 to
6a9752e
Compare
Create a release workflow and Dockerfile for creating an image