Repository navigation
Fix XML metadata order when moving curated datasets - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37. Moving a rated or featured dataset between acquisition activities could make the record fail XML schema validation and prevent saving. The move now preserves schema-valid ordering of dataset metadata and curation.
Changes
<meta>elements before<curation>when curation exists.Testing
.venv/bin/python -m django test tests --settings=tests.test_settings— 228 tests passed.git diff --check— passed.Risks and deployment
This changes XML element placement only when copied setup metadata is added to a curated dataset. No migration or configuration change is required. Deploy the updated application image to make the fix available on the demo.