DAT-1116 - #3
Open
marcj-planet wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Changes are straightforward build/test improvements and the added test aligns with the intended polymorphic model behavior without introducing risky logic changes.
Pull request overview
This PR updates the generator project’s build configuration and adds a focused JUnit test to validate discriminator-based polymorphic deserialization for generated OpenAPI union models.
Changes:
- Added a new JUnit test (
PolymorphicModelsTest) to verify discriminator values resolve to the expected concrete model types. - Updated multiple dependency/plugin versions and switched the OpenAPI input spec path to
src/main/resources/openapi.json. - Added
build-helper-maven-pluginto include generated OpenAPI sources as a compile source root, and added the JUnit Jupiter engine dependency for test execution.
File summaries
| File | Description |
|---|---|
src/test/java/ch/datatrans/model/PolymorphicModelsTest.java |
Adds a discriminator-to-concrete-type assertion test for polymorphic generated models. |
pom.xml |
Updates dependency/plugin versions, points generation to openapi.json, and ensures generated sources are compiled and JUnit engine is present. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.