Skip to content

DAT-1116 - #3

Open
marcj-planet wants to merge 1 commit into
mainfrom
DAT-1116
Open

DAT-1116#3
marcj-planet wants to merge 1 commit into
mainfrom
DAT-1116

Conversation

@marcj-planet

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are straightforward build/test improvements and the added test aligns with the intended polymorphic model behavior without introducing risky logic changes.

Pull request overview

This PR updates the generator project’s build configuration and adds a focused JUnit test to validate discriminator-based polymorphic deserialization for generated OpenAPI union models.

Changes:

  • Added a new JUnit test (PolymorphicModelsTest) to verify discriminator values resolve to the expected concrete model types.
  • Updated multiple dependency/plugin versions and switched the OpenAPI input spec path to src/main/resources/openapi.json.
  • Added build-helper-maven-plugin to include generated OpenAPI sources as a compile source root, and added the JUnit Jupiter engine dependency for test execution.
File summaries
File Description
src/test/java/ch/datatrans/model/PolymorphicModelsTest.java Adds a discriminator-to-concrete-type assertion test for polymorphic generated models.
pom.xml Updates dependency/plugin versions, points generation to openapi.json, and ensures generated sources are compiled and JUnit engine is present.
Review details
  • Files reviewed: 2/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants