Repository navigation
fix: bugsweep week 2026-W34 #9908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d4fe2ba
fix: evict poisoned smart-wearable cache entry on failed metadata fet…
decentraland-bot 91b66df
fix: drop inbound direct messages when the Friends feature is disable…
decentraland-bot 2c1ac8e
fix: report Segment external flush failures as warnings, not Sentry e…
decentraland-bot 2b132ec
fix: fail fast with an error on insecure non-loopback realms instead …
decentraland-bot 53841a4
fix: return a JSON-RPC error for disallowed scene Web3 methods instea…
decentraland-bot f005dda
fix: default the Places tab to Most Active so live-user scenes surfac…
decentraland-bot 3ab182a
Revert "fix: fail fast with an error on insecure non-loopback realms …
lorenzo-ranciaffi c04d90f
Revert "fix: report Segment external flush failures as warnings, not …
lorenzo-ranciaffi 45b40b8
Revert "fix: drop inbound direct messages when the Friends feature is…
lorenzo-ranciaffi b0eabda
fix: keep the LiveKit chat room disconnected in local scene developme…
lorenzo-ranciaffi 83d28b0
fix: keep a scene.json-less smart wearable smart, log and evict inste…
lorenzo-ranciaffi edad8bd
refactor: move the JSON-RPC method-not-found code to a const (#9833)
lorenzo-ranciaffi 3853c9e
refactor: condense PR comments to single-line why-comments
lorenzo-ranciaffi 00399b4
reduce lint errors
lorenzo-ranciaffi aa3e205
feat: surface analytics disk-full errors and warn the user with a popup
lorenzo-ranciaffi 2b7227e
Merge branch 'dev' into fix/bugsweep-week-2026-w34
lorenzo-ranciaffi c1e6551
Merge branch 'dev' into fix/bugsweep-week-2026-w34
lorenzo-ranciaffi ef18064
fix: make the disk-full popup reliable and stop exception spam for it
lorenzo-ranciaffi d03ca1c
moved diskfull error in the bridge
lorenzo-ranciaffi 14fef20
win rust bridge compiled
lorenzo-ranciaffi ca6b7ba
Merge branch 'dev' into fix/bugsweep-week-2026-w34
lorenzo-ranciaffi 1670ba9
refined comments
lorenzo-ranciaffi 04f89fe
Merge branch 'dev' into fix/bugsweep-week-2026-w34
lorenzo-ranciaffi e095044
code review
lorenzo-ranciaffi ea239d6
code review
lorenzo-ranciaffi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
Explorer/Assets/DCL/Infrastructure/Utility/EventBus/AnalyticsDiskFullDetected.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| namespace Utility | ||
| { | ||
| /// <summary>Lives in Utility rather than DCL.Analytics so UI-layer subscribers need no dependency on the analytics assembly.</summary> | ||
| public readonly struct AnalyticsDiskFullDetected { } | ||
|
lorenzo-ranciaffi marked this conversation as resolved.
|
||
| } | ||
2 changes: 2 additions & 0 deletions
2
Explorer/Assets/DCL/Infrastructure/Utility/EventBus/AnalyticsDiskFullDetected.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
Explorer/Assets/DCL/PluginSystem/Global/AnalyticsDiskFullPopupPlugin.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| using Arch.SystemGroups; | ||
| using Cysharp.Threading.Tasks; | ||
| using DCL.Diagnostics; | ||
| using DCL.UI; | ||
| using DCL.UI.ErrorPopup; | ||
| using DCL.Utilities.Extensions; | ||
| using DCL.Utility.Types; | ||
| using MVC; | ||
| using System; | ||
| using System.Threading; | ||
| using UnityEngine; | ||
| using Utility; | ||
|
|
||
| namespace DCL.PluginSystem.Global | ||
| { | ||
| public class AnalyticsDiskFullPopupPlugin : IDCLGlobalPluginWithoutSettings | ||
| { | ||
| private readonly IEventBus analyticsEventBus; | ||
| private readonly IMVCManager mvcManager; | ||
| private readonly CancellationTokenSource cts = new (); | ||
| private IDisposable? subscription; | ||
|
|
||
| // The event repeats with every failing flush; the popup must show once per session | ||
| private bool popupShown; | ||
|
|
||
| public AnalyticsDiskFullPopupPlugin(IEventBus analyticsEventBus, IMVCManager mvcManager) | ||
| { | ||
| this.analyticsEventBus = analyticsEventBus; | ||
| this.mvcManager = mvcManager; | ||
| } | ||
|
|
||
| public void InjectToWorld(ref ArchSystemsWorldBuilder<Arch.Core.World> builder, in GlobalPluginArguments arguments) { } | ||
|
|
||
| public UniTask InitializeAsync(NoExposedPluginSettings settings, CancellationToken ct) | ||
| { | ||
| subscription = analyticsEventBus.Subscribe<AnalyticsDiskFullDetected>(OnDiskFull); | ||
| return UniTask.CompletedTask; | ||
| } | ||
|
|
||
| private void OnDiskFull(AnalyticsDiskFullDetected evt) | ||
| { | ||
| if (popupShown) | ||
| return; | ||
|
|
||
| popupShown = true; | ||
| ShowPopupAsync(cts.Token).Forget(); | ||
| } | ||
|
|
||
| private async UniTaskVoid ShowPopupAsync(CancellationToken ct) | ||
| { | ||
| var data = new ErrorPopupData( | ||
| UIProperty<Sprite>.UseDefault, | ||
| UIProperty<string>.From("Storage Full"), | ||
| UIProperty<string>.From("Your device is running out of disk space. Free up space to keep Decentraland working correctly.")); | ||
|
|
||
| EnumResult<TaskError> result = await mvcManager.ShowAsync(new ShowCommand<ErrorPopupView, ErrorPopupData>(data), ct) | ||
| .SuppressToResultAsync(ReportCategory.ANALYTICS); | ||
|
|
||
| // A show that failed never reached the user, so the next disk-full event may retry | ||
| if (result.Error is { State: not TaskError.Cancelled }) | ||
| popupShown = false; | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| subscription?.Dispose(); | ||
| cts.SafeCancelAndDispose(); | ||
| } | ||
| } | ||
| } |
2 changes: 2 additions & 0 deletions
2
Explorer/Assets/DCL/PluginSystem/Global/AnalyticsDiskFullPopupPlugin.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.