tickettreap: Fix off-by-one in getByIndex - #3763
Open
jholdstock wants to merge 1 commit into
Open
Conversation
davecgh
requested changes
Aug 16, 2026
jholdstock
changed the title
This fixes an off-by-one bug in the validation of the getByIndex idx param. This was not caught by tests because the test was only checking that a panic was raised and not where the panic originated. This check was satisfied by a stdlib panic rather than the intended panic from dcrd code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an off-by-one bug in the validation of the getByIndex idx param. This was not caught by tests because the test was only checking that a panic was raised and not where the panic originated. This check was satisfied by a stdlib panic rather than the intended panic from dcrd code.