fix: Supports Windows non-UTF8 encoding - #11867
Merged
Merged
Conversation
yuanchaoa
enabled auto-merge (rebase)
August 20, 2026 06:48
kylewanginchina
approved these changes
Aug 20, 2026
kylewanginchina
left a comment
kylewanginchina
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: replacing pcap::Device::list with direct pcap-sys name enumeration prevents unrelated non-UTF-8 descriptions from aborting interface discovery; list ownership is released through Drop. Required checks are tracked for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for:
fix: Supports Windows non-UTF8 encoding
Steps to reproduce the bug
Changes to fix the bug
Affected branches
Checklist