Skip to content

Fix INPUT availability for diag_subspace - #7835

Merged
mohanchen merged 1 commit into
deepmodeling:developfrom
Stardust0831:availability-diag-subspace-pr
Aug 19, 2026
Merged

Fix INPUT availability for diag_subspace#7835
mohanchen merged 1 commit into
deepmodeling:developfrom
Stardust0831:availability-diag-subspace-pr

Conversation

@Stardust0831

@Stardust0831 Stardust0831 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Linked Issue

Ref #7719 — normalize INPUT availability into a machine-readable form and align it with parameter validation.

Unit Tests and/or Case Tests for my changes

  • Commands run: cmake --build build -j2 --target abacus_pw_ser; ctest --test-dir build -V -R MODULE_IO_availability; regenerated docs/parameters.yaml and docs/advanced/input_files/input-main.md; git diff --check; repository governance check.
  • Result summary: The affected target and 20 focused availability tests passed, generated documentation is consistent, and repository checks passed.
  • Checks not run, with reason: None.

What's changed?

  • Restrict diag_subspace availability to plane-wave calculations with ks_solver=dav_subspace.
  • Add a focused registration test for the availability expression.
  • Regenerate the INPUT parameter metadata and advanced input documentation.

Governance Notes

  • INPUT/docs changes: The availability metadata and generated INPUT documentation are updated.
  • Core module impact: Limited to INPUT availability registration and its focused test; solver implementation is unchanged.
  • Exceptions requested: None.

@mohanchen mohanchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanchen mohanchen added the Input&Output Suitable for coders without knowing too many DFT details label Aug 19, 2026
@mohanchen
mohanchen merged commit 0a91426 into deepmodeling:develop Aug 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Input&Output Suitable for coders without knowing too many DFT details

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants