Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed cache-publication rename could discard a completed build and return an incomplete or nonexistent destination as a cache hit.
Check the destination's
.committedmarker before accepting the failed rename. If the marker is absent or cannot be inspected, throwfilesystem_errorwith the original rename error and both paths. Keep the entry uncommitted so its temporary build remains available for retry and is cleaned up on destruction. Existing incomplete destinations are left untouched after a failed rename.Adds CPU regressions for normal publication, an overlapping committed winner, incomplete destinations, permission failures, and retries. Adds a CUDA regression for a failed publication followed by successful compilation and kernel launch after the test removes its own incomplete fixture.
Validation:
Fixes #3.