Keep interface validation active under python -O - #15
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertchecks for unsupportedbegin/hintargumentswith explicit validation that remains active under
python -Ooutput_idxwhose dtype disagrees withindices_type, also before output allocation or backend dispatchminimal fake while exercising the real Python interface with PyTorch tensors
Testing
The same regression test projected onto unmodified commit
0f03b68748b304863fdf0181a11458d04ae533a9fails all three expected-rejectioncases under
python -O: the removable assertions allow the fake backend toreceive unsupported arguments or a mismatched output dtype. Its positive
control still passes. The candidate rejects all three invalid calls before
backend dispatch and sends the valid call to the backend exactly once.
Scope
This is Python interface validation only. It does not change CUDA kernels,
supported argument combinations, numerical behavior, or performance.