Repository navigation
SF-05: gate on relative l2 only, peak distance reported - #87
Merged
Merged
Conversation
Steve decided on 2026-10-16, from the meeting naming L2 error as the primary metric, that the evaluation gate blocks only a rise in mean relative l2, with a default margin of zero. This supersedes answer T8, which also blocked any rise in peak distance and held the model back on a noisy focal metric, such as the workbench round that was rejected while peak distance fell from 1.81 to 0.80 mm. max_peak_distance_increase_mm now defaults to None, which skips the check. A config that sets it to a number still gets the peak distance check as before. All six metrics stay in eval_report.json, overall and per region. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stedrew
added a commit
that referenced
this pull request
Oct 17, 2026
The gate now decides on relative l2 alone, D8, so the intro no longer says peak distance blocks by default; --peak-margin-mm adds it back as an opt-in. Gate-approved models now wait in the registry as pending, D7: the demo lists them, signs off the newest as the coordinator and shows it approved. Needs PR #87 and PR #88 merged first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Steve decided on 2026-10-16, after the meeting named L2 error as the primary metric, that the evaluation gate decides on relative l2 only.
{"enabled": true, "max_rel_l2_increase": 0.0, "max_peak_distance_increase_mm": null}. Any rise in mean relative l2 blocks the candidate.eval_report.json, overall and per region, but do not block.max_peak_distance_increase_mmis now an opt-in check. A config that sets it to a number behaves as before.gate.pydocstring andTASK_GUIDE.mdupdated.Tests
DecideTestcases:manage.py test starfish.controller.tasks.babel_brain_fno: 143 tests, OK. Run locally on Python 3.12 with CPU torch and a fakeredis server.jsonliteandmice; they touch no gate code. CI installs the R packages.Follow-up
The demo on #86,
workbench/babelbrain-demo/run_demo.py, still describes the old rule: its intro line, its--peak-margin-mmhelp text, which says "default 0, answer T8". Its README still reads correctly, since--peak-margin-mmnow opts into the peak check. Its gate narration itself readseval_report.jsonand will show the new decisions correctly.🤖 Generated with Claude Code