Skip to content

Cleaning up solutions blocking further bug discovery #114

Open
Open
Cleaning up solutions blocking further bug discovery#114

Description

@szepeviktor
szepeviktor
opened on Apr 14, 2019

How about

  1. redesigning helpers loading using $this->add_helper outside a class (maybe a static method?)
  2. moving from extract towards wp_parse_args
  3. undefined $user in https://github.com/devgeniem/dustpress/blob/master/models/user-activate.php#L60
  4. introduce TravisCI: syntax check, coding style, static analysis

@Nomafin What do you think?

Activity

  1. szepeviktor
    changed the title [-]Cleaning up solutions block further bug discover [/-] [+]Cleaning up solutions blocking further bug discover [/+] on Apr 14, 2019

  2. Nomafin commented on Apr 14, 2019

    @Nomafin
    Nomafin
    on Apr 14, 2019
    Contributor

    Hi Viktor!

    These suggestions sound good. I'll review your pull request and these questions more accurately in Monday or Tuesday and comment them further then.

  3. szepeviktor commented on May 8, 2019

    @szepeviktor
    szepeviktor
    on May 8, 2019
    ContributorAuthor

    @Nomafin Static analysis for WordPress was just released: https://packagist.org/packages/szepeviktor/phpstan-wordpress

  4. szepeviktor
    changed the title [-]Cleaning up solutions blocking further bug discover [/-] [+]Cleaning up solutions blocking further bug discovery[/+] on Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions