#2193: add alternatives and dependencies to auto-completion entries - #2390
#2193: add alternatives and dependencies to auto-completion entries#2390Hiepiscus wants to merge 4 commits into
Conversation
Coverage Report for CI Build 33607517526Coverage increased (+0.02%) to 73.63%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions7 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
Great work on adding alternatives and dependencies to the auto-completion entries! I've followed your testing instructions and everything worked fine. On Step 9 you wrote that the output should only contain -Dexec.args= but I guess you meant it should contain -Dexec.args= but not -Dexec.mainClass=. If that's true then everything worked as intended and you can move it to In Review 😄. Also you might have to change the Changelog entry to the next release but i couldn't flag it since this branch isn't up-to-date with main.
0bfa1a1 to
cf640f8
Compare
@samuelkos17 Thanks for the review! You are correct. I meant that the output should contain -Dexec.args= but not -Dexec.mainClass=. I have updated the test instructions accordingly. |
This PR fixes #2193
This PR extends the auto-completion model with support for alternatives and dependencies between
CompletionEntryobjects.Implemented changes:
CompletionEntrywith alternative relationships.CompletionEntrywith dependency groups.AutoCompletionRegistry.addAlternative(String, String)connects two previously registered completion entries.addDependency(String, List<String>)registers an OR-dependency group for a previously registered entry.IllegalStateExceptionif a referenced candidate has not been registered withadd(String).exec:javaandexec:execare registered as alternatives.-Dexec.mainClass=depends onexec:java.-Dexec.args=depends on eitherexec:javaorexec:exec.CompleteTest:Testing instructions
build-local-dev.shide mvn exec:execand use the auto completion with<tab><tab>exec:javaide mvn -Dand use<tab><tab>-Dexec.mainClass=or-Dexec.args=is not in the outputide mvn exec:java -Dand use `-Dexec.mainClass=or-Dexec.args=ide mvn exec:exec -Dand use<tab><tab>-Dexec.args=and does not contain-Dexec.mainClass=.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc