#950: avoid non-interactive GPG handling for Rancher Desktop on SUSE - #2413
Open
cap-juan wants to merge 1 commit into
Open
#950: avoid non-interactive GPG handling for Rancher Desktop on SUSE#2413cap-juan wants to merge 1 commit into
cap-juan wants to merge 1 commit into
Conversation
Collaborator
Coverage Report for CI Build 33758527195Coverage increased (+0.03%) to 73.826%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #950
Implemented changes:
Testing instructions
Please add concise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Start a SUSE Linux environment where the Rancher repository signing key is not already trusted.
Run: ide install docker
Verify that the generated Rancher Desktop installation command does not contain:
--no-gpg-checksor--non-interactiveVerify that Zypper asks how the repository signing key should be handled and allows the user to choose between rejecting, temporarily trusting, or permanently trusting the key.
Verify that other Zypper-based native package installations remain non-interactive.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidocChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet