Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 63.49% 65.28% +1.78%
==========================================
Files 47 40 -7
Lines 6821 5919 -902
Branches 2422 2422
==========================================
- Hits 4331 3864 -467
+ Misses 1182 747 -435
Partials 1308 1308 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Growl1234
force-pushed
the
cmake
branch
3 times, most recently
from
October 12, 2026 16:24
2b7b939 to
89ded45
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly for convenience of Fedora packaging as it requires Fortran modules to be installed under
%{fmoddir}.Note: We shouldn't simply adopt what's done for mctc-lib etc:
Downstream sets
CMAKE_INSTALL_INCLUDEDIRto%{_lib}/gfortran/modulesas a workaround, which is not applicable to s-dftd3 as it has public C header. This is also an issue on dftd4 and tblite side; will fix them soon.