Verilog: handle streaming concatenation with multiple stream expressions - #1947
Merged
Merged
Conversation
kroening
force-pushed
the
fix-streaming-concat
branch
from
June 28, 2026 18:34
50a5154 to
a324735
Compare
kroening
marked this pull request as draft
June 28, 2026 19:34
kroening
changed the title
kroening
force-pushed
the
fix-streaming-concat
branch
from
August 9, 2026 14:58
a324735 to
c679cf3
Compare
kroening
marked this pull request as ready for review
August 9, 2026 14:58
Collaborator
|
Can we please have a test? |
kroening
force-pushed
the
fix-streaming-concat
branch
2 times, most recently
from
September 5, 2026 23:30
a590118 to
f17fa70
Compare
Collaborator
Author
|
Now with test. |
The preconditions expr.op().operands().size() == 1 and
expr.op1().operands().size() == 1 assumed the stream body always
contains a single expression. Streaming concatenations can have multiple
expressions (e.g., {<<{a, b, c}}). Iterate over all operands instead.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kroening
force-pushed
the
fix-streaming-concat
branch
from
September 5, 2026 23:52
f17fa70 to
4edf40f
Compare
tautschnig
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
convert_unary_exprandconvert_binary_exprcases forID_verilog_streaming_concatenation_*had hard preconditionsoperands().size() == 1that assumed the stream body always contains exactly one expression. Streaming concatenations can have multiple expressions (e.g.,{<<{a, b, c}}). Iterate over all operands instead of asserting on the count.Test plan
🤖 Generated with Claude Code