Repository navigation
feat: Hide one off props - #103
Merged
Merged
Conversation
The single migration did not complete on a large database. The index rebuild and the classifier reset now run in separate migrations.
The search adds a created date range with an index on created, sort by rating and by dependents, and a set of search presets. The period selection for the created and updated filters persists in the URL. The positive_props and negative_props parameters are now include_props and exclude_props. The default sort is now TrendWeek.
When Steam returns a result other than OK for a file, the item update actor sets the item to hidden. The list, item and dependency queries skip hidden items. An upsert sets hidden to false, so an item that Steam returns again becomes visible.
The shared hoop uses the salvo default levels, so zstd changes from Fastest to Default.
The design comes from Claude Design. The card now opens the item page from any point on it. A Steam icon replaces the Steam button. Assisted-by: Claude <noreply@anthropic.com>
Add the "continuation" type to the features prompt. A continuation is a re-upload that keeps the abandoned mod of a different author working. The prompt reads the credit line as evidence for this type, and puts "continuation" after the type of the content. Increase the limit of the types array from 2 to 3, so that a continuation keeps two content types. Assisted-by: Claude <noreply@anthropic.com>
The classifier makes many properties that occur on one item only. A new system property now gets the hidden status (-2) until a second item in the same app gets it. Then the classifier accepts the new link and the hidden links. The migration hides the existing one-off system links. Assisted-by: Claude <noreply@anthropic.com>
The item queries filter on hidden = false. The test schemas did not define the field, so every seeded item dropped out of the results. Assisted-by: Claude <noreply@anthropic.com>
Contributor
Svelte Check ResultsFound 79 errors and 7 warnings (86 total) with the files in this PR. ui/src/routes/app/[id]/[[slug]]/+page.tsui/src/routes/app/[id]/[[slug]]/+page.ts:51:61Error: Argument of type 'Date' is not assignable to parameter of type 'string | number | bigint | boolean'.
paramList.push(['last_updated_greater_than_equals', BigInt(lastUpdatedGte.v) / BigInt(1000)]);ui/src/routes/app/[id]/[[slug]]/+page.ts:55:58Error: Argument of type 'Date' is not assignable to parameter of type 'string | number | bigint | boolean'.
paramList.push(['last_updated_less_than_equals', BigInt(lastUpdatedLte.v) / BigInt(1000)]);ui/src/routes/app/[id]/[[slug]]/+page.ts:59:56Error: Argument of type 'Date' is not assignable to parameter of type 'string | number | bigint | boolean'.
paramList.push(['created_greater_than_equals', BigInt(createdGte.v) / BigInt(1000)]);ui/src/routes/app/[id]/[[slug]]/+page.ts:63:53Error: Argument of type 'Date' is not assignable to parameter of type 'string | number | bigint | boolean'.
paramList.push(['created_less_than_equals', BigInt(createdLte.v) / BigInt(1000)]);ui/src/routes/app/[id]/[[slug]]/+page.ts:81:18Error: Property 'tags' does not exist on type '{}'.
tags.v = app.v.tags.filter((tag) => app.v.default_tags.some((e) => e === tag));ui/src/routes/app/[id]/[[slug]]/+page.ts:81:31Error: Parameter 'tag' implicitly has an 'any' type.
tags.v = app.v.tags.filter((tag) => app.v.default_tags.some((e) => e === tag));ui/src/routes/app/[id]/[[slug]]/+page.ts:81:45Error: Property 'default_tags' does not exist on type '{}'.
tags.v = app.v.tags.filter((tag) => app.v.default_tags.some((e) => e === tag));ui/src/routes/app/[id]/[[slug]]/+page.ts:81:64Error: Parameter 'e' implicitly has an 'any' type.
tags.v = app.v.tags.filter((tag) => app.v.default_tags.some((e) => e === tag));ui/src/routes/app/[id]/[[slug]]/+page.ts:82:9Error: Property 'default_tags' does not exist on type '{}'.
app.v.default_tags.forEach((tag) => {ui/src/routes/app/[id]/[[slug]]/+page.ts:82:31Error: Parameter 'tag' implicitly has an 'any' type.
app.v.default_tags.forEach((tag) => {ui/src/routes/app/[id]/[[slug]]/+page.ts:93:18Error: Property 'name' does not exist on type '{}'.
{ title: app.v.name ?? params.id, href: `/app/${params.id}/${params.slug}` }ui/src/routes/app/[id]/[[slug]]/+page.ts:97:44Error: Argument of type '((string | number)[] | (string | bigint)[])[]' is not assignable to parameter of type 'string | Record<string, string> | string[][] | URLSearchParams | undefined'.
Type '((string | number)[] | (string | bigint)[])[]' is not assignable to type 'string[][]'.
Type '(string | number)[] | (string | bigint)[]' is not assignable to type 'string[]'.
Type '(string | number)[]' is not assignable to type 'string[]'.
Type 'string | number' is not assignable to type 'string'.
Type 'number' is not assignable to type 'string'.
fetch(`/api/list?` + new URLSearchParams(paramList).toString()).then(async (res) => {ui/src/routes/app/[id]/[[slug]]/+page.ts:148:2Error: Type 'string' is not assignable to type 'undefined'.
title.v = paramTitle;ui/src/routes/app/[id]/[[slug]]/+page.ts:155:2Error: Type 'string' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = paramLastUpdatedPeriod;ui/src/routes/app/[id]/[[slug]]/+page.ts:175:2Error: Type 'string' is not assignable to type 'undefined'.
createdPeriod.v = paramCreatedPeriod;ui/src/routes/admin/+page.svelteui/src/routes/admin/+page.svelte:19:1Warn: This reference only captures the initial value of `data`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
data.users.then((data) => (users = data ?? []));ui/src/routes/admin/+page.svelte:21:1Warn: This reference only captures the initial value of `data`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
data.properties.then((data) => (properties = data ?? []));ui/src/routes/admin/+page.svelte:15:17Error: Member 'data' implicitly has an 'any' type.
let { data }: { data } = $props();ui/src/routes/admin/+page.svelte:19:18Error: Parameter 'data' implicitly has an 'any' type.
data.users.then((data) => (users = data ?? []));ui/src/routes/admin/+page.svelte:21:23Error: Parameter 'data' implicitly has an 'any' type.
data.properties.then((data) => (properties = data ?? []));ui/src/routes/admin/+page.svelte:183:43Error: Argument of type 'number' is not assignable to parameter of type 'string'.
cell: (info) => renderSnippet(userLink, info.row.original.id),ui/src/routes/app/[id]/[[slug]]/search.svelteui/src/routes/app/[id]/[[slug]]/search.svelte:57:38Error: Object literal may only specify known properties, and 'value' does not exist in type 'EventTarget'.
updatedSelectionChange({ target: { value: lastUpdatedPeriod.v } });ui/src/routes/app/[id]/[[slug]]/search.svelte:65:38Error: Object literal may only specify known properties, and 'value' does not exist in type 'EventTarget'.
createdSelectionChange({ target: { value: createdPeriod.v } });ui/src/routes/app/[id]/[[slug]]/search.svelte:209:24Error: Property 'value' does not exist on type 'EventTarget'.
switch (event.target.value) {ui/src/routes/app/[id]/[[slug]]/search.svelte:245:38Error: Property 'value' does not exist on type 'EventTarget'.
lastUpdatedPeriod.v = event.target.value;ui/src/routes/app/[id]/[[slug]]/search.svelte:253:24Error: Property 'value' does not exist on type 'EventTarget'.
switch (event.target.value) {ui/src/routes/app/[id]/[[slug]]/search.svelte:289:34Error: Property 'value' does not exist on type 'EventTarget'.
createdPeriod.v = event.target.value;ui/src/routes/app/[id]/[[slug]]/search.svelte:293:22Error: Parameter 'event' implicitly has an 'any' type.
function submitForum(event) {ui/src/routes/app/[id]/[[slug]]/search.svelte:321:34Error: Property 'class' does not exist on type 'never'.
itemToValue: (item) => `${item.class}:${item.value}`,ui/src/routes/app/[id]/[[slug]]/search.svelte:321:48Error: Property 'value' does not exist on type 'never'.
itemToValue: (item) => `${item.class}:${item.value}`,ui/src/routes/app/[id]/[[slug]]/search.svelte:322:35Error: Property 'class' does not exist on type 'never'.
itemToString: (item) => `${item.class}:${item.value}`ui/src/routes/app/[id]/[[slug]]/search.svelte:322:49Error: Property 'value' does not exist on type 'never'.
itemToString: (item) => `${item.class}:${item.value}`ui/src/routes/app/[id]/[[slug]]/search.svelte:326:28Error: Parameter 'details' implicitly has an 'any' type.
let onPresetValueChange = (details) => {ui/src/routes/app/[id]/[[slug]]/search.svelte:332:4Error: Type '"quarter"' is not assignable to type 'undefined'.
createdPeriod.v = 'quarter';ui/src/routes/app/[id]/[[slug]]/search.svelte:333:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:339:4Error: Type '"all"' is not assignable to type 'undefined'.
createdPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:340:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:346:4Error: Type '"all"' is not assignable to type 'undefined'.
createdPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:347:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:353:4Error: Type '"all"' is not assignable to type 'undefined'.
createdPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:354:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:360:4Error: Type '"week"' is not assignable to type 'undefined'.
createdPeriod.v = 'week';ui/src/routes/app/[id]/[[slug]]/search.svelte:361:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:367:4Error: Type '"week"' is not assignable to type 'undefined'.
createdPeriod.v = 'week';ui/src/routes/app/[id]/[[slug]]/search.svelte:368:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:374:4Error: Type '"year"' is not assignable to type 'undefined'.
createdPeriod.v = 'year';ui/src/routes/app/[id]/[[slug]]/search.svelte:375:4Error: Type '"all"' is not assignable to type 'undefined'.
lastUpdatedPeriod.v = 'all';ui/src/routes/app/[id]/[[slug]]/search.svelte:470:7Error: Type '(event: InputEvent) => void' is not assignable to type 'FormEventHandler<HTMLSelectElement>'.
Types of parameters 'event' and 'event' are incompatible.
Type 'Event & { currentTarget: EventTarget & HTMLSelectElement; }' is missing the following properties from type 'InputEvent': data, dataTransfer, inputType, isComposing, and 5 more.
oninput={createdSelectionChange}ui/src/routes/app/[id]/[[slug]]/search.svelte:611:7Error: Type '(event: InputEvent) => void' is not assignable to type 'FormEventHandler<HTMLSelectElement>'.
Types of parameters 'event' and 'event' are incompatible.
Type 'Event & { currentTarget: EventTarget & HTMLSelectElement; }' is missing the following properties from type 'InputEvent': data, dataTransfer, inputType, isComposing, and 5 more.
oninput={updatedSelectionChange}ui/src/routes/app/[id]/[[slug]]/search.svelte:685:7Error: Type 'ListCollection<never>' is not assignable to type 'ListCollection<any>'.
Types of property 'copy' are incompatible.
Type '(items?: never[] | undefined) => ListCollection<never>' is not assignable to type '(items?: any[] | undefined) => ListCollection<any>'.
Types of parameters 'items' and 'items' are incompatible.
Type 'any[] | undefined' is not assignable to type 'never[] | undefined'.
Type 'any[]' is not assignable to type 'never[]'.
Type 'any' is not assignable to type 'never'.
{collection}ui/src/routes/app/[id]/[[slug]]/search.svelte:711:17Error: Argument of type 'null' is not assignable to parameter of type 'ArrayLike<unknown> | Iterable<unknown>'.
{#each foundProps as item (item.class + ':' + item.value)}ui/src/routes/app/[id]/[[slug]]/search.svelte:711:37Error: 'item' is of type 'unknown'.
{#each foundProps as item (item.class + ':' + item.value)}ui/src/routes/app/[id]/[[slug]]/search.svelte:711:56Error: 'item' is of type 'unknown'.
{#each foundProps as item (item.class + ':' + item.value)}ui/src/routes/app/[id]/[[slug]]/search.svelte:715:41Error: Type 'unknown' is not assignable to type '{ class: string; value: string; upvote_count: number; vote_count: number; status: 0 | 1 | -1; vote_state: 0 | 1 | -1; }'.
<Property loggedIn={false} property={item} hideVote={true} />ui/src/routes/app/[id]/[[slug]]/search.svelte:751:8Error: Property 'itemID' is missing in type '{ loggedIn: false; property: { vote_state: 0; vote_count: number; upvote_count: number; status: 1; class: string; value: string; }; hideVote: true; subtle: true; }' but required in type 'Props'.
<Propertyui/src/routes/item/[item]/[[slug]]/BodyTab.svelteui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:103:26Error: Parameter 'item' implicitly has an 'any' type.
{#snippet itemCardCompact(item)}ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:161:23Error: Parameter 'item' implicitly has an 'any' type.
{#snippet sortedDetail(item)}ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:25:17Error: Parameter 'item' implicitly has an 'any' type.
function filter(item) {ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:26:42Error: Parameter 'e' implicitly has an 'any' type.
const itemTags = (item.tags || []).map((e) => e.id);ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:29:48Error: Parameter 'langId' implicitly has an 'any' type.
const itemLangs = (item.languages || []).map((langId) => whichLang(langId));ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:31:49Error: Parameter 'langName' implicitly has an 'any' type.
selectedLangs.length === 0 || itemLangs.some((langName) => selectedLangs.includes(langName));ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:39:23Error: Parameter 'b' implicitly has an 'any' type.
const sortFunction = (b, a) => {ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:39:26Error: Parameter 'a' implicitly has an 'any' type.
const sortFunction = (b, a) => {ui/src/routes/item/[item]/[[slug]]/BodyTab.svelte:54:47Error: Parameter 'e' implicitly has an 'any' type.
let filtered = $derived((items || []).filter((e) => filter(e)).toSorted(sortFunction));ui/src/routes/item/[item]/[[slug]]/Body.svelteui/src/routes/item/[item]/[[slug]]/Body.svelte:17:27Warn: This reference only captures the initial value of `app`. Did you mean to reference it inside a derived instead?
https://svelte.dev/e/state_referenced_locally
let selectedTags = $state(app.default_tags);ui/src/routes/item/[item]/[[slug]]/Body.svelte:32:3Warn: This reference only captures the initial value of `item`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
item.dependants.map(mapTags).flat().concat(item.dependencies.map(mapTags).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:32:46Warn: This reference only captures the initial value of `item`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
item.dependants.map(mapTags).flat().concat(item.dependencies.map(mapTags).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:40:3Warn: This reference only captures the initial value of `item`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
item.dependants.map(mapLanguages).flat().concat(item.dependencies.map(mapLanguages).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:40:51Warn: This reference only captures the initial value of `item`. Did you mean to reference it inside a closure instead?
https://svelte.dev/e/state_referenced_locally
item.dependants.map(mapLanguages).flat().concat(item.dependencies.map(mapLanguages).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:17:27Error: 'app' is of type 'unknown'.
let selectedTags = $state(app.default_tags);ui/src/routes/item/[item]/[[slug]]/Body.svelte:20:18Error: Parameter 'item' implicitly has an 'any' type.
function mapTags(item) {ui/src/routes/item/[item]/[[slug]]/Body.svelte:21:24Error: Parameter 'tag' implicitly has an 'any' type.
return item.tags.map((tag) => {ui/src/routes/item/[item]/[[slug]]/Body.svelte:26:23Error: Parameter 'item' implicitly has an 'any' type.
function mapLanguages(item) {ui/src/routes/item/[item]/[[slug]]/Body.svelte:32:3Error: 'item' is of type 'unknown'.
item.dependants.map(mapTags).flat().concat(item.dependencies.map(mapTags).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:32:46Error: 'item' is of type 'unknown'.
item.dependants.map(mapTags).flat().concat(item.dependencies.map(mapTags).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:40:3Error: 'item' is of type 'unknown'.
item.dependants.map(mapLanguages).flat().concat(item.dependencies.map(mapLanguages).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:40:51Error: 'item' is of type 'unknown'.
item.dependants.map(mapLanguages).flat().concat(item.dependencies.map(mapLanguages).flat())ui/src/routes/item/[item]/[[slug]]/Body.svelte:67:11Error: 'item' is of type 'unknown'.
{@html item.description}ui/src/routes/item/[item]/[[slug]]/Body.svelte:81:50Error: 'item' is of type 'unknown'.
>Dependencies <sup class="text-primary-500">{item.dependencies.length}</sup>ui/src/routes/item/[item]/[[slug]]/Body.svelte:84:49Error: 'item' is of type 'unknown'.
>Required By <sup class="text-primary-500">{item.dependants.length}</sup>ui/src/routes/item/[item]/[[slug]]/Body.svelte:136:13Error: Type 'unknown' is not assignable to type 'string'.
value={tag.id}ui/src/routes/item/[item]/[[slug]]/Body.svelte:171:13Error: Type 'String' is not assignable to type 'string'.
'string' is a primitive, but 'String' is a wrapper object. Prefer using 'string' when possible.
value={whichLang(lang)}ui/src/routes/item/[item]/[[slug]]/Body.svelte:171:30Error: Argument of type 'unknown' is not assignable to parameter of type 'Number'.
value={whichLang(lang)}ui/src/routes/item/[item]/[[slug]]/Body.svelte:174:24Error: Argument of type 'unknown' is not assignable to parameter of type 'Number'.
{whichLang(lang)}ui/src/routes/item/[item]/[[slug]]/Body.svelte:187:71Error: 'item' is of type 'unknown'.
<BodyTab {selectedTags} {selectedLangs} {sort} {filterName} items={item.dependencies} />ui/src/routes/item/[item]/[[slug]]/Body.svelte:191:71Error: 'item' is of type 'unknown'.
<BodyTab {selectedTags} {selectedLangs} {sort} {filterName} items={item.dependants} />Last Updated: 13th October at 01:05 (4e54d94) |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Split the OpenID verify function in AuthActor into smaller functions. Add the test_ prefix to the auth test names.
disconsented
force-pushed
the
feat/hide-one-off-props
branch
from
October 13, 2026 00:14
362f079 to
f52902a
Compare
disconsented
force-pushed
the
feat/hide-one-off-props
branch
from
October 13, 2026 01:04
3bc58f9 to
27d98b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headline feature here is properties generated by ML will not appear until they appear more than once, I figure that one offs are just not useful.
At some point, I'll delete these to clear up DB space, over what time period is . . . messy at best.
With a smattering of other things like normal: