Skip to content

Remove unused using directives from Aapt2.cs#12043

Merged
jonathanpeppers merged 2 commits into
mainfrom
copilot/fix-finder-remove-unused-usings
Jul 13, 2026
Merged

Remove unused using directives from Aapt2.cs#12043
jonathanpeppers merged 2 commits into
mainfrom
copilot/fix-finder-remove-unused-usings

Conversation

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Aapt2.cs carried several unused imports in its using block, which added noise and overstated the file's actual dependencies. This change trims the file to only the namespaces it references.

  • Using cleanup

    • Removed six unused directives from src/Xamarin.Android.Build.Tasks/Tasks/Aapt2.cs
    • Preserved the existing ordering of the remaining directives
  • Scope

    • No task logic, behavior, or signatures changed
    • No test code or project configuration changed
using System;
using System.IO;
using System.Threading;
using System.Text;
using Microsoft.Build.Utilities;
using Microsoft.Build.Framework;
using System.Collections.Generic;
using System.Collections.Concurrent;
using Xamarin.Android.Tools;
using Microsoft.Android.Build.Tasks;

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused using directives in Aapt2.cs Remove unused using directives from Aapt2.cs Jul 12, 2026
Copilot AI requested a review from jonathanpeppers July 12, 2026 02:56
@jonathanpeppers jonathanpeppers marked this pull request as ready for review July 13, 2026 13:02
Copilot AI review requested due to automatic review settings July 13, 2026 13:02
@jonathanpeppers jonathanpeppers merged commit f5964bc into main Jul 13, 2026
43 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-finder-remove-unused-usings branch July 13, 2026 13:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces noise in the Xamarin.Android.Build.Tasks Aapt2 task implementation by removing unused using directives, keeping the file’s referenced dependencies accurate without altering task behavior.

Changes:

  • Removed unused using directives (System.Diagnostics, System.Linq, System.Xml, System.Xml.Linq, System.Text.RegularExpressions, and a System.Threading.Tasks alias).
  • Kept the remaining using directives in their existing order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] Remove unused using directives in Aapt2.cs

4 participants