Repository navigation
fix: treat zstd as a binary content-encoding - #313
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kulesy
marked this pull request as draft
September 7, 2026 06:33
kulesy
marked this pull request as ready for review
September 7, 2026 07:47
Owner
|
Thanks, will cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #312
TL;DR Adds
zstdto the content-encodings treated as binary in the AWS and Azure providers. Responses compressed with zstd are now base64-encoded like gzip and br ones, and every other encoding behaves exactly as before.Pain: a response with
Content-Encoding: zstdisn't recognised as binary, so its compressed bytes get stringified as utf-8 and the body arrives corrupted. Chrome and Safari now ask for zstd and koa-compress prefers it, so a stock Koa app behind this wrapper serves broken responses to modern browsers.Solution: adds
zstdtoBINARY_ENCODINGSin both providers, along with a test for content-encoding detection, which had none.