Repository navigation
Fix generic derive output and document HexDebug secrecy - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates derive-hex derives to support generic types safely, use hygienic absolute paths, and document HexDebug value exposure.
Changes:
- Preserve generics and
whereclauses. - Use absolute
::corepaths. - Add generic derive tests and security documentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
derive-hex/tests/hex_test.rs |
Adds bounded generic derive coverage. |
derive-hex/src/lib.rs |
Updates generated implementations and documents HexDebug secrecy implications. Nit (4 votes): add the related [Unreleased] changelog entry linked to issue #44. |
Suppressed comments (1)
derive-hex/src/lib.rs:61
- This warning is only in the proc-macro item's rustdoc, while the published
derive-hexdocumentation is sourced fromREADME.mdand thedusk-bytesREADME also documentsHexDebugwithout this warning. Please add the secrecy guidance to the user-facing README documentation so users following the package examples see it.
/// Do not derive `HexDebug` for types containing secrets. Formatting such a
/// value exposes its complete serialized representation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HDauven
force-pushed
the
fix/generic-derive-output
branch
from
August 23, 2026 02:19
97e4460 to
4566ed6
Compare
HDauven
force-pushed
the
fix/generic-derive-output
branch
2 times, most recently
from
August 23, 2026 03:07
c1a8c63 to
4b0c12b
Compare
d-sonuga
reviewed
Aug 24, 2026
HDauven
force-pushed
the
fix/generic-derive-output
branch
from
August 25, 2026 10:45
4b0c12b to
e150a59
Compare
HDauven
force-pushed
the
fix/generic-derive-output
branch
2 times, most recently
from
August 25, 2026 12:27
1090f30 to
c6171d0
Compare
HDauven
force-pushed
the
fix/generic-derive-output
branch
from
August 25, 2026 12:58
c6171d0 to
b6893d7
Compare
Neotamandua
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whereclauses inHexandHexDebugimplementations::corepaths in generated codeHexDebugexposes the complete serialized valueCloses #44