Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The coordinated version and changelog updates are complete and internally consistent.
0 open findings
What changed in this PR
Prepares the coordinated phoenix-core 0.36.0 and phoenix-circuits 0.9.0 releases.
Changes:
- Bumps both crate versions and aligns the circuits dependency.
- Moves unreleased entries into versioned changelog sections.
- Updates release comparison links.
| File | Description |
|---|---|
core/CHANGELOG.md |
Adds the 0.36.0 release section and links. |
core/Cargo.toml |
Bumps phoenix-core to 0.36.0. |
circuits/CHANGELOG.md |
Adds the 0.9.0 release section and links. |
circuits/Cargo.toml |
Bumps the crate and its core dependency. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
07a29db to
4b46cc9
Compare
|
Force-pushed: rebased on the amended stack. No changes. |
Move the unreleased changelog entries under the new versions, dated when they are released, and add the entry for the circuits' move to phoenix-core 0.36.0.
4b46cc9 to
359d299
Compare
|
Force-pushed: rebased on the amended stack. Only changelog context changed. |
moCello
left a comment
moCello
left a comment
There was a problem hiding this comment.
APPROVE — Both version bumps match the breaking changes in their notes, and the circuits crate requires the new core version. The compare links follow the tag scheme of each crate.
One note below. It concerns a stale entry that the new release header makes permanent.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.36.0] - <date TBD> |
There was a problem hiding this comment.
NOTE: The 0.36.0 section records two dusk-jubjub updates, to v0.16 and to v0.15.2. The release ships only v0.16, so the v0.15.2 entry is stale.
Context: 0.35.1 shipped with dusk-jubjub = "0.15". An unreleased commit raised it to 0.15.2, and the #311 update then replaced that with 0.16 (core/Cargo.toml:16). The 0.15.2 entry predates this change. The new release header freezes it into notes that do not change after the tag.
Fix: Remove the Update dusk-jubjub to v0.15.2 entry from the 0.36.0 section. Keep the [#288] link definition, because other entries still cite #288.
Stacked on #326.
Bumps phoenix-core to 0.36.0 and phoenix-circuits to 0.9.0, and moves the unreleased changelog entries under the new versions. The release date goes in when the release is tagged.