Repository navigation
fix(monitor): return 400 for invalid message bodies - #506
Merged
jfaltermeier merged 1 commit intoNov 6, 2026
Merged
jfaltermeier merged 1 commit into
jfaltermeier merged 1 commit into
Conversation
Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
jfaltermeier
self-requested a review
November 6, 2026 12:51
jfaltermeier
approved these changes
Nov 6, 2026
jfaltermeier
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM! The license check CI errors are caused by the PR coming from a fork. This is unrelated to this change and should pass once merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /monitor/messagecould return HTTP 200 when requiredlevelormessagefields were missing or empty. The Theia handler ended the response before setting 400 and then continued into the success response; the VS Code monitor also returned success for these requests.Both handlers now set HTTP 400 before ending the response and return immediately. Existing authorization and valid-message behavior remain unchanged.
Adds 52 HTTP regression tests across both implementations, covering invalid bodies, JSON parsing, authorization, and standard/fullscreen message delivery. Test sources and generated test output are excluded from the VS Code extension package.
Validation:
Validation used local HTTP integration with captured UI callbacks; no live IDE session or Kubernetes deployment was used. Existing unrelated lint and third-party webpack warnings remain.
Fixes #431