Allow selecting fragment source with columns#4760
Merged
greg-rychlewski merged 3 commits intoJul 21, 2026
Merged
Conversation
greg-rychlewski
commented
Jul 21, 2026
greg-rychlewski
force-pushed
the
select_fragment_source
branch
from
July 21, 2026 02:51
98cac7e to
6b88c49
Compare
greg-rychlewski
force-pushed
the
select_fragment_source
branch
from
July 21, 2026 03:13
7fb5d43 to
5d06a69
Compare
josevalim
reviewed
Jul 21, 2026
josevalim
approved these changes
Jul 21, 2026
josevalim
left a comment
josevalim
left a comment
Member
There was a problem hiding this comment.
One comment and ship it!!!!
greg-rychlewski
commented
Jul 21, 2026
Comment on lines
+2255
to
+2257
| if columns = meta[:column_names] do | ||
| {{:map, Enum.map(columns, &{&1, {:value, :any}})}, | ||
| Enum.map(columns, &select_field(&1, ix, :always))} |
Member
Author
There was a problem hiding this comment.
@josevalim Sorry while making your change I actually noticed we already had a way to handle map creation without adding a new {:source, :fragment, ...} construct. Just letting you take a look again before mering
josevalim
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to the last PR.