Skip to content

Widen @glimmer/syntax range to >= 0.95.0 - #262

Merged
NullVoxPopuli merged 1 commit into
ember-tooling:mainfrom
johanrd:chore/glimmer-syntax-range
Oct 21, 2026
Merged

Widen @glimmer/syntax range to >= 0.95.0#262
NullVoxPopuli merged 1 commit into
ember-tooling:mainfrom
johanrd:chore/glimmer-syntax-range

Conversation

@johanrd

@johanrd johanrd commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lets ember-eslint-parser use @glimmer/syntax 0.97.0.

ember-estree 0.6.x still pulls 0.95.0 until #263 moves ember-estree to 0.9.

@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

🏎️ Benchmark Comparison

Parse

Benchmark Control (p50) Experiment (p50) Δ
🟢 gts small 1019.01 ms 927.73 ms -9.0%
🟢 gts medium 1783.14 ms 1626.81 ms -8.8%
🟢 gts large 828.51 ms 768.52 ms -7.2%
⚪ gjs small 822.42 ms 817.62 ms -0.6%
🟢 gjs medium 1488.71 ms 1421.10 ms -4.5%
🟢 gjs large 675.54 ms 639.89 ms -5.3%
🟠 hbs small 133.23 ms 138.60 ms +4.0%
⚪ hbs medium 746.89 ms 734.55 ms -1.7%
⚪ hbs large 839.16 ms 827.28 ms -1.4%

🟢 faster · 🔴 slower · 🟠 slightly slower · ⚪ within 2%

Full mitata output 
clk: ~3.10 GHz
cpu: AMD EPYC 7763 64-Core Processor
runtime: node 24.21.0 (x64-linux)

benchmark                   avg (min … max) p75 / p99    (min … top 1%)
------------------------------------------- -------------------------------
gts small (control)             1.03 s/iter    1.06 s     █      █         
                       (861.22 ms … 1.37 s)    1.16 s ▅▅  █     ▅█ ▅▅   ▅ ▅
                    ( 15.08 mb …  87.58 mb)  34.64 mb ██▁▁█▁▁▁▁▁██▁██▁▁▁█▁█

gts small (experiment)       975.49 ms/iter 997.71 ms    █      █          
                       (836.52 ms … 1.26 s)    1.15 s ▅ ▅█ ▅▅ ▅ █   ▅     ▅
                    ( 15.06 mb …  87.03 mb)  39.25 mb █▁██▁██▁█▁█▁▁▁█▁▁▁▁▁█

                             ┌                                            ┐
                                ╷        ┌───────────────┬───┐            ╷
         gts small (control)    ├────────┤               │   ├────────────┤
                                ╵        └───────────────┴───┘            ╵
                             ╷     ┌────────────┬───┐                    ╷
      gts small (experiment) ├─────┤            │   ├────────────────────┤
                             ╵     └────────────┴───┘                    ╵
                             └                                            ┘
                             836.52 ms           996.99 ms           1.16 s

summary
  gts small (experiment)
   1.06x faster than gts small (control)

------------------------------------------- -------------------------------
gts medium (control)            1.83 s/iter    1.86 s     █                
                          (1.66 s … 2.22 s)    1.98 s     █       █        
                    ( 84.04 mb … 101.70 mb)  87.83 mb █▁█▁█▁▁▁██▁▁██▁▁▁▁▁▁█

gts medium (experiment)         1.68 s/iter    1.71 s    █                 
                          (1.54 s … 2.13 s)    1.77 s ▅  █▅ ▅ ▅▅   ▅ ▅ ▅  ▅
                    ( 83.60 mb … 101.77 mb)  87.97 mb █▁▁██▁█▁██▁▁▁█▁█▁█▁▁█

                             ┌                                            ┐
                                          ╷    ┌──────────┬──┐            ╷
        gts medium (control)              ├────┤          │  ├────────────┤
                                          ╵    └──────────┴──┘            ╵
                             ╷   ┌─────────┬──┐     ╷
     gts medium (experiment) ├───┤         │  ├─────┤
                             ╵   └─────────┴──┘     ╵
                             └                                            ┘
                             1.54 s              1.76 s              1.98 s

summary
  gts medium (experiment)
   1.09x faster than gts medium (control)

------------------------------------------- -------------------------------
gts large (control)          878.58 ms/iter 877.23 ms      ██              
                       (799.77 ms … 1.26 s) 900.42 ms ▅  ▅▅██      ▅ ▅   ▅▅
                    ( 16.63 mb …  87.35 mb)  34.63 mb █▁▁████▁▁▁▁▁▁█▁█▁▁▁██

gts large (experiment)       833.63 ms/iter 830.06 ms  █                   
                       (757.17 ms … 1.21 s) 956.50 ms  █▂                  
                    ( 16.30 mb …  87.82 mb)  35.04 mb ▆██▁▁▁▁▆▁▁▁▆▁▁▁▁▁▁▁▁▆

                             ┌                                            ┐
                                       ╷   ┌────────────┬    ╷
         gts large (control)           ├───┤            │────┤
                                       ╵   └────────────┴    ╵
                             ╷ ┌──────────────┬                           ╷
      gts large (experiment) ├─┤              │───────────────────────────┤
                             ╵ └──────────────┴                           ╵
                             └                                            ┘
                             757.17 ms         856.84 ms          956.50 ms

summary
  gts large (experiment)
   1.05x faster than gts large (control)

------------------------------------------- -------------------------------
gjs small (control)          853.12 ms/iter 855.78 ms   █                  
                       (768.35 ms … 1.15 s) 975.26 ms   █   █              
                    ( 32.12 mb …  47.68 mb)  34.68 mb ███▁▁██▁██▁▁▁▁▁▁▁▁▁▁█

gjs small (experiment)       837.64 ms/iter 840.57 ms    █     █           
                       (759.52 ms … 1.11 s) 904.42 ms ▅▅ █▅   ▅█ ▅▅       ▅
                    ( 32.04 mb …  47.48 mb)  34.50 mb ██▁██▁▁▁██▁██▁▁▁▁▁▁▁█

                             ┌                                            ┐
                               ╷  ┌──────────────┬                        ╷
         gjs small (control)   ├──┤              │────────────────────────┤
                               ╵  └──────────────┴                        ╵
                             ╷   ┌───────────┬┐            ╷
      gjs small (experiment) ├───┤           │├────────────┤
                             ╵   └───────────┴┘            ╵
                             └                                            ┘
                             759.52 ms         867.39 ms          975.26 ms

summary
  gjs small (experiment)
   1.02x faster than gjs small (control)

------------------------------------------- -------------------------------
gjs medium (control)            1.53 s/iter    1.50 s         █            
                          (1.38 s … 2.04 s)    1.65 s      █  █            
                    ( 20.73 mb …  93.71 mb)  67.71 mb █▁▁█▁█▁███▁█▁▁▁▁▁▁▁▁█

gjs medium (experiment)         1.47 s/iter    1.47 s █                    
                          (1.36 s … 1.96 s)    1.51 s █  ▅▅ ▅ ▅▅ ▅  ▅ ▅   ▅
                    ( 21.02 mb …  93.90 mb)  73.28 mb █▁▁██▁█▁██▁█▁▁█▁█▁▁▁█

                             ┌                                            ┐
                                ╷         ┌────────────┬                  ╷
        gjs medium (control)    ├─────────┤            │──────────────────┤
                                ╵         └────────────┴                  ╵
                             ╷   ┌────────────┬      ╷
     gjs medium (experiment) ├───┤            │──────┤
                             ╵   └────────────┴      ╵
                             └                                            ┘
                             1.36 s              1.50 s              1.65 s

summary
  gjs medium (experiment)
   1.04x faster than gjs medium (control)

------------------------------------------- -------------------------------
gjs large (control)          723.34 ms/iter 694.72 ms    █                 
                       (651.53 ms … 1.07 s) 808.35 ms    █                 
                    (419.09 kb …  70.82 mb)  40.36 mb ███████▁▁█▁▁▁▁▁▁▁▁▁▁█

gjs large (experiment)       683.75 ms/iter 682.13 ms   █                  
                    (612.95 ms … 996.64 ms) 767.17 ms   █                  
                    (218.02 kb …  70.91 mb)  36.17 mb ▇▁█▇▇▇▁▁▁▇▇▁▁▁▁▁▁▁▁▁▇

                             ┌                                            ┐
                                      ╷   ┌───────────┬                   ╷
         gjs large (control)          ├───┤           │───────────────────┤
                                      ╵   └───────────┴                   ╵
                             ╷   ┌───────────┬                   ╷
      gjs large (experiment) ├───┤           │───────────────────┤
                             ╵   └───────────┴                   ╵
                             └                                            ┘
                             612.95 ms         710.65 ms          808.35 ms

summary
  gjs large (experiment)
   1.06x faster than gjs large (control)

------------------------------------------- -------------------------------
hbs small (control)          151.75 ms/iter 158.68 ms     █             █  
                    (118.83 ms … 281.09 ms) 163.01 ms ▅ ▅ █ ▅▅   ▅   ▅  █ ▅
                    ( 51.32 mb …  56.60 mb)  53.68 mb █▁█▁█▁██▁▁▁█▁▁▁█▁▁█▁█

hbs small (experiment)       153.44 ms/iter 155.29 ms           █          
                    (112.99 ms … 301.98 ms) 163.46 ms ▅ ▅  ▅▅   █▅    ▅▅ ▅▅
                    ( 51.26 mb …  56.25 mb)  53.71 mb █▁█▁▁██▁▁▁██▁▁▁▁██▁██

                             ┌                                            ┐
                                  ╷       ┌─────────────────────┬─────┐   ╷
         hbs small (control)      ├───────┤                     │     ├───┤
                                  ╵       └─────────────────────┴─────┘   ╵
                             ╷           ┌───────────────────────┬─┐      ╷
      hbs small (experiment) ├───────────┤                       │ ├──────┤
                             ╵           └───────────────────────┴─┘      ╵
                             └                                            ┘
                             112.99 ms         138.23 ms          163.46 ms

summary
  hbs small (control)
   1.01x faster than hbs small (experiment)

------------------------------------------- -------------------------------
hbs medium (control)         786.97 ms/iter 771.91 ms  █                   
                       (736.74 ms … 1.07 s) 829.53 ms  ██                  
                    (  9.07 mb …  82.94 mb)  33.02 mb █████▁▁▁█▁▁▁▁▁▁▁▁▁█▁█

hbs medium (experiment)      767.63 ms/iter 750.62 ms    █                 
                    (715.65 ms … 987.54 ms) 815.35 ms    █                 
                    (  9.14 mb …  82.85 mb)  33.12 mb ██▁█████▁▁▁▁▁▁▁▁▁▁▁██

                             ┌                                            ┐
                                     ╷ ┌─────────────────┬                ╷
        hbs medium (control)         ├─┤                 │────────────────┤
                                     ╵ └─────────────────┴                ╵
                             ╷    ┌───────────────┬                 ╷
     hbs medium (experiment) ├────┤               │─────────────────┤
                             ╵    └───────────────┴                 ╵
                             └                                            ┘
                             715.65 ms         772.59 ms          829.53 ms

summary
  hbs medium (experiment)
   1.03x faster than hbs medium (control)

------------------------------------------- -------------------------------
hbs large (control)          863.58 ms/iter 846.94 ms   █ █                
                       (828.23 ms … 1.09 s) 889.83 ms   █ █ █              
                    ( 53.55 mb …  64.86 mb)  55.51 mb █▁███▁█▁▁▁▁▁▁▁▁▁▁▁▁▁█

hbs large (experiment)       854.54 ms/iter 843.25 ms  █                   
                       (819.26 ms … 1.07 s) 880.06 ms  █ ▅                 
                    ( 53.51 mb …  64.86 mb)  55.49 mb ▇█▁█▇▁▁▁▇▁▁▁▁▇▁▁▁▁▁▁▇

                             ┌                                            ┐
                                   ╷   ┌─────────────────┬                ╷
         hbs large (control)       ├───┤                 │────────────────┤
                                   ╵   └─────────────────┴                ╵
                             ╷  ┌──────────────────┬                ╷
      hbs large (experiment) ├──┤                  │────────────────┤
                             ╵  └──────────────────┴                ╵
                             └                                            ┘
                             819.26 ms         854.54 ms          889.83 ms

summary
  hbs large (experiment)
   1.01x faster than hbs large (control)
### Project mode (type-aware)
Benchmark Control (p50) Experiment (p50) Δ
🟠 project warm parse x150 627.60 ms 650.56 ms +3.7%
⚪ project parse+typed x150 650.61 ms 647.08 ms -0.5%
⚪ projectService warm parse x150 627.06 ms 632.22 ms +0.8%
⚪ projectService parse+typed x150 674.07 ms 679.58 ms +0.8%

🟢 faster · 🔴 slower · 🟠 slightly slower · ⚪ within 2%

Full mitata output 
clk: ~3.04 GHz
cpu: AMD EPYC 7763 64-Core Processor
runtime: node 24.21.0 (x64-linux)

benchmark                                   avg (min … max) p75 / p99    (min … top 1%)
----------------------------------------------------------- -------------------------------
project warm parse x150 (control)            637.03 ms/iter 642.25 ms █ █ █                
                                    (614.85 ms … 681.26 ms) 673.31 ms █▁███▁▁█▁█▁▁▁▁▁▁█▁▁▁█
                                  gc(293.27 ms … 310.75 ms) 114.41 mb (102.83 mb…124.50 mb)

project warm parse x150 (experiment)         652.65 ms/iter 658.27 ms            ▃ █       
                                    (587.38 ms … 707.96 ms) 697.04 ms ▆▁▁▁▁▆▆▁▁▁▁█▆█▁▁▁▁▆▁▆
                                  gc(294.75 ms … 315.00 ms) 112.10 mb (111.51 mb…112.80 mb)

                                             ┌                                            ┐
                                                        ╷  ┌─────┬──┐           ╷
           project warm parse x150 (control)            ├──┤     │  ├───────────┤
                                                        ╵  └─────┴──┘           ╵
                                             ╷            ┌─────────────┬─┐               ╷
        project warm parse x150 (experiment) ├────────────┤             │ ├───────────────┤
                                             ╵            └─────────────┴─┘               ╵
                                             └                                            ┘
                                             587.38 ms         642.21 ms          697.04 ms

summary
  project warm parse x150 (control)
   1.02x faster than project warm parse x150 (experiment)

----------------------------------------------------------- -------------------------------
project parse+typed x150 (control)           657.70 ms/iter 671.35 ms        █             
                                    (633.42 ms … 695.43 ms) 681.28 ms ▆▁▆▆▁▁▁█▆▆▁▁▁▁▁▁▆▆▁▁▆
                                  gc(297.83 ms … 310.38 ms) 113.67 mb (111.81 mb…118.15 mb)

project parse+typed x150 (experiment)        649.37 ms/iter 657.77 ms            █▃        
                                    (615.59 ms … 681.00 ms) 671.89 ms ▆▁▆▁▁▁▁▁▁▁▆██▁▁▆▁▁▆▁▆
                                  gc(304.54 ms … 327.99 ms) 112.61 mb (110.95 mb…116.98 mb)

                                             ┌                                            ┐
                                                         ╷    ┌───────────┬────────┐      ╷
          project parse+typed x150 (control)             ├────┤           │        ├──────┤
                                                         ╵    └───────────┴────────┘      ╵
                                             ╷                  ┌───┬─────┐         ╷
       project parse+typed x150 (experiment) ├──────────────────┤   │     ├─────────┤
                                             ╵                  └───┴─────┘         ╵
                                             └                                            ┘
                                             615.59 ms         648.44 ms          681.28 ms

summary
  project parse+typed x150 (experiment)
   1.01x faster than project parse+typed x150 (control)

----------------------------------------------------------- -------------------------------
projectService warm parse x150 (control)     629.51 ms/iter 636.36 ms        █             
                                    (611.62 ms … 658.17 ms) 640.35 ms █▁▁▁█▁██▁▁▁█▁█▁█▁██▁█
                                  gc(306.34 ms … 334.62 ms) 115.74 mb (113.34 mb…116.85 mb)

projectService warm parse x150 (experiment)  638.43 ms/iter 641.03 ms █     █              
                                    (619.91 ms … 676.96 ms) 660.76 ms █▁█▁███▁▁██▁▁▁▁▁▁▁█▁█
                                  gc(305.05 ms … 320.26 ms) 112.36 mb (111.93 mb…113.13 mb)

                                             ┌                                            ┐
                                             ╷      ┌────────┬──────┐  ╷
    projectService warm parse x150 (control) ├──────┤        │      ├──┤
                                             ╵      └────────┴──────┘  ╵
                                                     ╷  ┌─────────────┬─┐                 ╷
 projectService warm parse x150 (experiment)         ├──┤             │ ├─────────────────┤
                                                     ╵  └─────────────┴─┘                 ╵
                                             └                                            ┘
                                             611.62 ms         636.19 ms          660.76 ms

summary
  projectService warm parse x150 (control)
   1.01x faster than projectService warm parse x150 (experiment)

----------------------------------------------------------- -------------------------------
projectService parse+typed x150 (control)    679.49 ms/iter 692.11 ms          █      █    
                                    (650.62 ms … 718.70 ms) 701.44 ms ███▁▁█▁▁▁█▁▁▁▁█▁██▁▁█
                                  gc(308.90 ms … 332.88 ms) 117.72 mb (116.74 mb…121.67 mb)

projectService parse+typed x150 (experiment) 682.50 ms/iter 694.14 ms  █     ██            
                                    (654.44 ms … 726.11 ms) 721.82 ms ███▁▁▁▁██▁▁▁██▁▁▁▁▁▁█
                                  gc(316.45 ms … 331.39 ms) 116.29 mb (114.63 mb…121.07 mb)

                                             ┌                                            ┐
                                             ╷   ┌─────────────┬───────┐     ╷
   projectService parse+typed x150 (control) ├───┤             │       ├─────┤
                                             ╵   └─────────────┴───────┘     ╵
                                               ╷ ┌───────────────┬───────┐                ╷
projectService parse+typed x150 (experiment)   ├─┤               │       ├────────────────┤
                                               ╵ └───────────────┴───────┘                ╵
                                             └                                            ┘
                                             650.62 ms         686.22 ms          721.82 ms

summary
  projectService parse+typed x150 (control)
   1x faster than projectService parse+typed x150 (experiment)

@johanrd johanrd mentioned this pull request Oct 21, 2026
Closed
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Oct 21, 2026
@NullVoxPopuli
NullVoxPopuli merged commit a75b421 into ember-tooling:main Oct 21, 2026
32 of 40 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johanrd @NullVoxPopuli