geoip: support additional maxmind database fields#46074
Open
tufitko wants to merge 1 commit into
Open
Conversation
Adds new geolocation field keys to the common geoip provider config and their extraction in the maxmind provider: city_geoname_id, latitude, longitude, time_zone, postal_code, region_name, region_geoname_id, subregion_geoname_id, country_geoname_id, continent_geoname_id and metro_code. Country-level GeoNames IDs follow the existing country ISO code semantics: the country database is preferred with a fallback to the city database. Adds UINT16 (metro code) and DOUBLE (latitude/longitude) entry data type support to the lookup result population. Motivation: parity with the nginx geoip2 module headers when migrating ingress from nginx to Envoy. Signed-off-by: Andrei Vydrin <andrey.vydrin@jetradar.com>
tufitko
requested a deployment
to
external-contributors
GitHub Actions
Waiting
|
Hi @tufitko, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: geoip: support additional maxmind database fields
Additional Description:
Risk Level: low?
Testing: tests addded
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]