chore: move dev-only packages out of dependencies - #477
Open
josecarneiro wants to merge 5 commits into
Open
Conversation
- @epilot/app-sdk: msw is only used by src/signature.test.ts, so move it from dependencies to devDependencies (only dist/ is published) - journey-client, validation-rules-client: drop openapi-backend, which is referenced nowhere in either package - all clients: remove unused webpack-4-era browser polyfills (buffer, https-browserify, stream-http, url, util) from dependencies - regenerate pnpm-lock.yaml Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CeCZHjvf7UPwexDX2zzLor
src/client.ts imports openapi-client-axios at runtime, but it was declared only in devDependencies, so the published tarball could not resolve it on a clean consumer install. Pre-existing, but this PR empties the package's dependencies block, which is the natural moment to fix it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WjZz3GtituheczbU2FSyEA
Without a changeset, changesets publishes none of these 52 packages, and the dependency removal would instead ride along silently in whatever bump an unrelated PR chooses next - typically a patch. Consumers on caret ranges would then lose the polyfills on their next install with nothing in the changelog explaining the broken build. A minor with an explicit upgrade note makes the change visible. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WjZz3GtituheczbU2FSyEA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up misplaced npm dependencies so consumers stop pulling packages they never use:
@epilot/app-sdk:mswmoved fromdependenciestodevDependencies. It is only imported bysrc/signature.test.ts, and onlydist/is published — so until now every app-sdk consumer installed the entire Mock Service Worker toolchain at runtime for nothing.tslibstays independencies(the tsconfig usesimportHelpers).journey-clientandvalidation-rules-client:openapi-backendremoved. It is referenced nowhere in either package (no imports in source, tests, or configs — verified by grep).buffer,https-browserify,stream-http,url,utilfromdependencies. These are webpack-4-era Node polyfills that no client imports and nobrowserfield references — unused legacy carried along by the client template.pnpm-lock.yamlviapnpm install(no other dependency changes).No scaffold/template for new clients references the polyfills, so regeneration won't reintroduce them.
Caveat: if a consumer's own webpack config relied on these polyfills being hoisted into
node_modules(e.g. viaresolve.fallbackentries pointing atbuffer,stream-http, etc.), they should now install those polyfills as their own dependencies.Test plan
@epilot/app-sdk:pnpm run buildpasses,pnpm run testpasses (4/4 tests incl. the msw-basedsignature.test.ts)journey-client: fullpnpm run build(openapi + typegen + tsc + webpack bundle) compiles successfullygit statusclean after builds — no unintended generated-file drift🤖 Generated with Claude Code
https://claude.ai/code/session_01CeCZHjvf7UPwexDX2zzLor
Generated by Claude Code