feat(entity-client, pricing-client): a select condition declares options like a select attribute - #478
Open
josecarneiro wants to merge 3 commits into
Open
feat(entity-client, pricing-client): a select condition declares options like a select attribute#478josecarneiro wants to merge 3 commits into
josecarneiro wants to merge 3 commits into
Conversation
…ons like a select attribute
Regenerate both clients from the updated Entity API and Pricing API specs:
a `ConditionDefinition` now declares a select condition's vocabulary under
`options`, whose entries are either a bare value or a `{ value, title }`
object, exactly as a select attribute's `options` — replacing the Entity
API's `values: string[]`. The Pricing API drops `allow_any` from the
definition, since a condition's vocabulary is always enforced.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01515iUBYHWajkSBDVD6Cp5z
…options description Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01515iUBYHWajkSBDVD6Cp5z
…ect condition descriptions Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01515iUBYHWajkSBDVD6Cp5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
@epilot/entity-clientand@epilot/pricing-clientfrom the updated Entity API and Pricing API specs (Conditional Pricing), plus theepilot-sdk-v2derived types/docs viapnpm generate, with a minor changeset for both clients and@epilot/sdk.A
selectcondition now follows aselectattribute's shape:ConditionDefinitiondeclares its vocabulary underoptions, whose entries are either a bare value or a{ value, title }object — replacing the Entity API'svalues: string[].allow_any(removed from the Pricing API'sConditionDefinition), since a variant can only ever pin a declared option.Specs were pulled from the local API repos (
npm run openapi <path>), so this can merge before the API deploys land; a laternpm run openapiagainst prod produces no further diff once they do.Companion MRs: entity-api and pricing-api (GitLab)
claude/conditional-pricing-select-options.Test plan
tsc --noEmitin both clients — cleanpnpm generateinpackages/epilot-sdk-v2— regenerated, biome cleantscerror count unchanged vsmain(2 pre-existing, unrelated)🤖 Generated with Claude Code
https://claude.ai/code/session_01515iUBYHWajkSBDVD6Cp5z
Generated by Claude Code