Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts subscript.fmuobs validation logging so that certain validation failures that do not stop processing are emitted as warnings rather than errors, matching the behavior described in issue #881.
Changes:
- Downgrade “unsupported observation classes” validation from
ERRORtoWARNING. - Downgrade the “observation dataframe is invalid” message from
ERRORtoWARNINGand clarify the wording.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
167
to
170
| non_supported_classes = set(obs_df["CLASS"]) - set(CLASS_SHORTNAME.keys()) | ||
| if non_supported_classes: | ||
| logger.error("Unsupported observation classes: %s", non_supported_classes) | ||
| logger.warning("Unsupported observation classes: %s", non_supported_classes) | ||
| failed = True |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 49 49
Lines 7528 7528
=======================================
Hits 6345 6345
Misses 1183 1183 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #881