Fix usort_stdin to only speak bytes - #359
Open
thatch wants to merge 3 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
The previous code read via sys.stdin.read() (text mode, system encoding) then passed through the deprecated usort_string() which re-encoded as UTF-8. A file with a PEP 263 non-UTF-8 coding declaration would be silently corrupted. Read sys.stdin.buffer and write sys.stdout.buffer directly, and call usort() with raw bytes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
usort_stdin had zero test coverage. Add StdinTest with two cases: sorting works at all via binary stdio, and a latin-1 file comes back as latin-1 bytes (\xb5) rather than UTF-8 (\xc2\xb5). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.