Activity

1. mcollina commented on Sep 26, 2024

   

   mcollina

   on Sep 26, 2024

   Member

   More actions

   I'm a bit lost. You are reading only one file in your example. Can you add a complete example with scripts to reproduce?
2. github-staff

   deleted a comment from amir1387aht on May 27, 2025
3. tasdflkjweio commented on Sep 18, 2025

   

   tasdflkjweio

   on Sep 18, 2025

   More actions

   MAX SIZE

   I'm not sure it's the same exact issue, but the file size does not appear to be respected at all, or maybe i'm doing something wrong?

   // generated by postman
   curl --location 'https://tr.localhost/api/file/upload' \
   --form 'metadata="{}";type=application/json' \
   --form '=@"/Users/a/Desktop/trashBlob-lg.txt"'
   

   ➜  Desktop stat -f%z trashBlob-lg.txt
   59419146
   

   fastify.register(async (fastify) => {
   
   	await fastify.register(multipart, {
   		limits: {
   			fileSize: MAX_FILE_UPLOAD_SIZE,
   			files: 1, // Maximum number of files per request
   			fieldNameSize: 100, // Max field name size in bytes
   			fieldSize: Bytes.addKiB(100).toBytes(), // 100 KiB max field value size
   			fields: 1, // Max number of non-file fields
   			headerPairs: 2000, // Max number of header key-value pairs
   		},
   	});
   
   	fastify.post<{
   		Reply: IFile;
   	}>('/api/file/upload', {
   		preHandler: async (request) => {
   			const fileData = await request.file({
   				limits: {
   					fileSize: MAX_FILE_UPLOAD_SIZE, // 20MB
   				},
   				throwFileSizeLimit: true,
   			});
   
   			if (!fileData) throw new Error('No file uploaded');
   
   			const fields = Object.values(fileData?.fields ?? {}) as Multipart[] & { type: 'field'; fieldname: string };
   			let metadata: Record<string, unknown> | null = null;
   
   			for (const field of fields) {
   				if (field!.type !== 'field') continue;
   				if (field!.fieldname === 'metadata') {
   					if (field!.mimetype !== 'application/json') throw new Error('Metadata must be a JSON object');
   					if (!isPlainObject(field.value)) throw new Error('Metadata must be a plain object.');
   					metadata = field.value as Record<string, unknown>;
   					break;
   				};
   			}
   
   			if (!metadata) throw new Error('Metadata is required. When forming a request, ensure the metadata field is listed before the file field.');
   
   			const mimeType = fileData.mimetype;
   			if (!isSupportedMimeType(mimeType)) throw new Error('Unsupported mime type');
   
   			request.body = {
   				file: fileData.file,
   				mimeType,
   				metadata,
   				filename: fileData.filename,
   			};
   		},
   		handler: async (request) => {
   			const { principal, log } = request;
   
   			const body = request.body as { file: Readable; mimeType: string; metadata: Record<string, unknown>; filename: string };
   			const { file, mimeType, metadata, filename } = body;
   
   			return await transact(async ({ repositories }: UnitOfWork) => {
   				const fileService = new FileService({ repositories });
   
   				const result = await fileService.saveNewFile({
   					fileContent: file,
   					mimeType,
   					filename,
   					metadata,
   					ownerId: principal!.id,
   					creatorId: principal!.id,
   					creatorType: 'user',
   					createdByAction: FileService.CREATE_ACTIONS.userUpload,
   					logger: log as ILogger,
   				});
   
   				return result;
   			});
   		},
   	});
   });
   

   this is accepted without any problem...shouldn't it throw as soon as the max content length limit is breached?

   MAX NUMBER OF FILES?

   also, the max number of files doesn't seem to be respected? i've attached this twice but my request goes through and succeeds.

   curl --location 'https://tr.localhost/api/file/upload' \
   --form 'metadata="{}";type=application/json' \
   --form '=@"/Users/a/Desktop/trashBlob-sm.txt"' \
   --form '=@"/Users/a/Desktop/trashBlob-sm.txt"'
   

   Is it because i'm only not explicitly reading the second file? I don't want to accept a request at all if the request is malformed. is there any way to optimize the validation without buffering the files completely?
4. soulseekah commented on Nov 17, 2025

   

   soulseekah

   on Nov 17, 2025

   Last edited by soulseekah

   More actions

   Might be related but neither files() nor saveRequestFiles() support higher override limits, which are checked in the preValidation hook. So take care that no limits can be raised, only lowered, I believe. This part of the documentation is incorrect:

   

   So preValidation only listens on to the global setting. Maybe it's a good idea to fix the documentation, since it's counter intuitive.

   And if this lands #580 things might change.

   👍React with 👍1Reacted by tasdflkjweio
5. Tony133

   added

   questionGeneral question about the projectGeneral question about the project

   on Oct 2, 2026
6. Tony133 commented on Oct 2, 2026

   

   Tony133

   on Oct 2, 2026

   Member

   More actions

   Closing this as it's not a bug: the fileSize limit is only applied while the file stream is consumed (e.g. with await file.toBuffer(), or by checking file.file.truncated once the stream has been fully read). See this note in the README.

   Since this issue is quite old, if you're still experiencing problems with the latest version, please open a new issue with a minimal reproduction in a cloneable git repository.
7. Tony133

   closed this as not plannedon Oct 2, 2026