Fix server error on some reports

[johnnyporkchops]

Summary

The new logic that shows file extension on DocumentPages(Reports about the fec) was causing some report pages to get a 500 server error with index out of range error. Since self.file_extension is a property on the model and not a field value it always returns "true" Example 500 error.

This logic was added in #5931

• Resolves #issue_number

Required reviewers

One frontend

Impacted areas of the application

Reports about the FEC pages that do not have a document associated with them like :
https://www.fec.gov/about/reports-about-fec/oig-reports/audit-agency-controls-governing-process-procurement-vendor-training-services-executive-summary/

modified: home/templates/home/document_page.html

How to test

• checkout and run branch
• Make sure reports in the list that that have Read more... links on this page do not get 500 Server error
  • http://127.0.0.1:8000/about/reports-about-fec/oig-reports/?category=audit+report
  • These are reports using DocumentPage that do not reference a file, the page itself is the report.
• @rfultz , I also went ahead and conditionally removed the paragraph tag with file link and info on pages that do not have a document per your earlier suggestion

[codecov]

Codecov Report

Merging #5957 (75820b3) into develop (bbb15a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5957   +/-   ##
========================================
  Coverage    78.16%   78.16%           
========================================
  Files          286      286           
  Lines         9167     9167           
  Branches       653      653           
========================================
  Hits          7165     7165           
  Misses        2002     2002           

[rfultz]

Can't seem to break it! :)