Skip to content

Download message for commitee filing PDFs that are 100K or more pages - #7216

Merged
JonellaCulmer merged 10 commits into
developfrom
feature/7195-large-pdf-dwnld-msg
Sep 15, 2026
Merged

JonellaCulmer merged 10 commits into
developfrom
feature/7195-large-pdf-dwnld-msg

Conversation

@johnnyporkchops

@johnnyporkchops johnnyporkchops commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary (required)

Required reviewers

one dev. one UX

Impacted areas of the application

PDF file download options on:
https://www.fec.gov/data/filings/?data_type=processed

Screenshots

dropdown-click-select-copy

How to test

*** REMOVE TEMP FEATURE DEPLOY TASK BEFORE MERGE! ***

@johnnyporkchops johnnyporkchops moved this to 👀 Ready in Website project Aug 19, 2026
@johnnyporkchops johnnyporkchops changed the title Alternate download message for committee filing PDFs that are 100K or more pages Download message for commitee filing PDFs that are 100K or more pages Aug 19, 2026

@rfultz rfultz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the row is expanded/has its child rows, the link text is invisible

Image

@JonellaCulmer

JonellaCulmer commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

@johnnyporkchops I'm unable to review this locally, but want to confirm that the rollover works across all three fields in the dropdown. If we need to adjust the color of the text, let me know. It also looks like the .pdf text is larger than the first two options and the alignment is slightly off.
Screenshot 2026-08-24 at 3 17 39 PM

@johnnyporkchops

johnnyporkchops commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor Author

@JonellaCulmer

but want to confirm that the rollover works across all three fields

By rollover, do you mean the gray background on hover?
A hover color that covers the whole enclosing box usually signifies that the whole area is clickable (according to MDN docs) so I overrode the cursor to only be a pointer (hand) , when hovering the link itself.

dropdown

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (faeaa0b) to head (3e07306).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7216   +/-   ##
========================================
  Coverage    79.73%   79.73%           
========================================
  Files          256      256           
  Lines         6756     6756           
========================================
  Hits          5387     5387           
  Misses        1369     1369           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JonellaCulmer

Copy link
Copy Markdown
Contributor

@johnnyporkchops I think this all looks really good! Last thing is that the text ".pdf not available..." looks bigger than the other two file type options in the dropdown. But my eyes may be playing tricks on me too. If you could make them all the same size, I would appreciate it. Or tell me to get new glasses.

@JonellaCulmer JonellaCulmer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much, @johnnyporkchops

@rfultz rfultz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonellaCulmer
JonellaCulmer merged commit 4c3ecd6 into develop Sep 15, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 Ready to ✅ Done in Website project Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add state to download dropdown for committee filings that are too large to download

3 participants