Repository navigation
fix(client): apply proxy_url on HTTP transport, not process env (#552) - #574
Merged
leandrodamascena merged 2 commits intoNov 2, 2026
Merged
leandrodamascena merged 2 commits into
leandrodamascena merged 2 commits into
Conversation
…umio#552) Stop writing HTTPS_PROXY from DynamoDB/S3/KMS constructors. Route proxy_url through aws-smithy-http-client ProxyConfig on each client's SDK HTTP stack so concurrent clients keep independent proxies and an existing HTTPS_PROXY stays untouched.
|
Member
|
Thanks, @ShahadatTest! I pushed two fixes to your branch: proxy requests now respect the configured timeouts, and AssumeRole uses the proxy too, including roles configured in profiles. I added Python tests for sync and async; the full local suite and examples passed. Thanks for working on this 🙂 |
leandrodamascena
approved these changes
Nov 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes #552.
proxy_urlon DynamoDB / S3 / KMS constructors previously didstd::env::set_var(\"HTTPS_PROXY\", …), which mutated process-wide state, overwrote an existing proxy, and leaked into child processes.This change:
HTTPS_PROXYenv mutation from all three constructorsproxy_urlviaaws-smithy-http-clientProxyConfigon each client's SDK HTTP transport in the sharedbuild_sdk_configpath (so lazy S3/KMS clients from a DynamoDB client inherit it)proxy_urlis per-client and does not set process envos.environand a child process's nativeHTTPS_PROXYstay unchangedTest plan
cargo check --libpytest tests/unit/test_proxy_url_env.py(needs built extension / CI)AI-assisted contribution.