Skip to content

chore: upgrade ucantone - #6

Merged
alanshaw merged 2 commits into
mainfrom
ash/chore/upgrade-ucantone
Jul 10, 2026
Merged

alanshaw merged 2 commits into
mainfrom
ash/chore/upgrade-ucantone

Conversation

@alanshaw

@alanshaw alanshaw commented Jul 9, 2026 •

Copy link
Copy Markdown
Member

Upgrades to the new ucantone version and deals with the fallout.

refs fil-forge/smelt#7

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades ucantone (and related dependencies) and refactors the delegator service to use the newer multikey/identity APIs across the runtime service, CLI generation command, client types, and system tests.

Changes:

  • Bump github.com/fil-forge/ucantone and github.com/fil-forge/libforge (plus related indirect deps).
  • Migrate service wiring from principal.Signer to identity.Identity and update UCAN issuance/verification calls accordingly.
  • Update DID document handling to return a did.Document and adjust tests/client to match.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/system_test.go Updates test issuers/proofs generation to multikey/issuer APIs and adjusts DID document assertions.
internal/services/registrar/delegator.go Switches delegator service identity from principal.Signer to identity.Identity and updates DID verification parsing.
internal/providers/providers.go Updates Fx provider to construct and return identity.Identity from key material.
internal/handlers/handlers.go Uses identity.Identity.DIDDocument() for DID document endpoint and updates handler wiring types.
cmd/gen.go Updates delegation generation command to use multikey signer/issuer flow and new PEM decode helper.
client/client.go Changes DID document client to decode into did.Document.
go.mod Dependency bumps for ucantone, libforge, and related indirects.
go.sum Updates checksums consistent with the dependency upgrades.
Comments suppressed due to low confidence (1)

test/system_test.go:134

  • In this helper, the fatal error message still says "indexing proof" even though this function generates the egress-tracking proof. This makes failures harder to diagnose when tests fail.
	if err != nil {
		t.Fatalf("failed to create indexing proof: %v", err)
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/handlers/handlers.go
@alanshaw
alanshaw merged commit 1775d58 into main Jul 10, 2026
8 checks passed
@alanshaw
alanshaw deleted the ash/chore/upgrade-ucantone branch July 10, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants