Repository navigation
chore: upgrade ucantone - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades ucantone (and related dependencies) and refactors the delegator service to use the newer multikey/identity APIs across the runtime service, CLI generation command, client types, and system tests.
Changes:
- Bump
github.com/fil-forge/ucantoneandgithub.com/fil-forge/libforge(plus related indirect deps). - Migrate service wiring from
principal.Signertoidentity.Identityand update UCAN issuance/verification calls accordingly. - Update DID document handling to return a
did.Documentand adjust tests/client to match.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/system_test.go | Updates test issuers/proofs generation to multikey/issuer APIs and adjusts DID document assertions. |
| internal/services/registrar/delegator.go | Switches delegator service identity from principal.Signer to identity.Identity and updates DID verification parsing. |
| internal/providers/providers.go | Updates Fx provider to construct and return identity.Identity from key material. |
| internal/handlers/handlers.go | Uses identity.Identity.DIDDocument() for DID document endpoint and updates handler wiring types. |
| cmd/gen.go | Updates delegation generation command to use multikey signer/issuer flow and new PEM decode helper. |
| client/client.go | Changes DID document client to decode into did.Document. |
| go.mod | Dependency bumps for ucantone, libforge, and related indirects. |
| go.sum | Updates checksums consistent with the dependency upgrades. |
Comments suppressed due to low confidence (1)
test/system_test.go:134
- In this helper, the fatal error message still says "indexing proof" even though this function generates the egress-tracking proof. This makes failures harder to diagnose when tests fail.
if err != nil {
t.Fatalf("failed to create indexing proof: %v", err)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyropy
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to the new ucantone version and deals with the fallout.
refs fil-forge/smelt#7