Repository navigation
Grant forge-perf's pr-run.yml pull-requests: write again - #94
Merged
Merged
Conversation
The pin at forge-perf 373f9ec asked for pull-requests: read, on the premise that comments and reactions on a pull request go through the issues API and need only issues: write. GitHub checks pull-requests for a comment whose issue is a pull request, so the first /forge-perf run on that pin, on fil-forge/piri#148, failed with a 403 at the reaction step. This pins 7b373a4, whose jobs hold pull-requests: write, and grants write, as fil-forge/piri#149 did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The permission matches the pinned workflow’s requirements and is validated by the successful equivalent Piri run.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the forge-perf workflow permissions so /forge-perf can react to and comment on pull requests.
Changes:
- Pins the corrected reusable workflow revision.
- Grants
pull-requests: write.
| File | Description |
|---|---|
.github/workflows/forge-perf.yml |
Updates the forge-perf pin and required permission. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fil-forge-bot Bot
added a commit
to fil-forge/infra-central
that referenced
this pull request
Sep 30, 2026
Published from fil-forge/hilt#94 - Digest: `sha256:124b659ce0853fc6ec983f187aa98f43ca78d8d26ee04bd5332bb4f5827fa007` - Commit: fil-forge/hilt@19be980 - Publish run: https://github.com/fil-forge/hilt/actions/runs/36723920256 Merging applies [`terraform/envs/dev/apps`](https://github.com/fil-forge/infra-central/tree/main/terraform/envs/dev/apps) with no further confirmation. Co-authored-by: fil-forge-bot[bot] <318653112+fil-forge-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull-requests: read. GitHub checkspull-requestsfor a comment or reaction whose issue is a pull request, so the first/forge-perfrun on that pin (perf: concurrent PutObject parts piri#148) failed withResource not accessible by integration (HTTP 403)at the reaction step.pull-requests: write, and grants write. fix: forge-perf needs PR write piri#149 made the same change, and the next run on piri#148 passed all four jobs./forge-perfon this repository fails at its first step.Test plan
actionlintclean.🤖 Generated with Claude Code