Repository navigation
feat: Attested Signatures + UCAN Principal Clarification - #4
Merged
Merged
Conversation
Call libforge's reusable go-workspace-test workflow so PRs that share a branch name with sibling repos are tested against those siblings' branches. When no sibling has a matching branch, the job is skipped and the normal go-test.yml remains the signal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Peeja
force-pushed
the
petra/feat/attested-signatures
branch
from
June 17, 2026 21:38
d707299 to
d20fcc2
Compare
* `multikey` and `absentee` go up a level to the root. * `verification.NewIssuer()` is gone; we can use `multikey.NewIssuer()` in every case we have. * The verifier factory types move `validator`. They're not inherent to *validation*, they're just used to configure the validator.
alanshaw
approved these changes
Jun 18, 2026
| "web": tierResolv.Resolve, | ||
| validator.WithDIDResolver(resolver.ByMethod{ | ||
| "key": key.Resolver, | ||
| "web": resolver.Tiered{wellKnownResolv, cacheResolv}, |
Member
There was a problem hiding this comment.
Just a thought, at a glance this reads like we're trying some other resolver before the cache - i.e. an ordering mistake. It might read better if we wrapped a caching resolver around a tiered well known and http.
Peeja
force-pushed
the
petra/feat/attested-signatures
branch
from
June 19, 2026 13:55
e437120 to
9ef4b09
Compare
Peeja
force-pushed
the
petra/feat/attested-signatures
branch
from
June 19, 2026 14:18
9ef4b09 to
4ed0dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fil-forge/ucantone#30