fix: re-use InsufficientStorage error instead of creating new error

[alanshaw]

No description provided.

[Copilot]

🟡 Changes recommended

It removes an exported constant in a public package (API break) and the updated docs can be clarified to more precisely describe the failure behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the /routing/use command’s documented/stable receipt-failure naming to align “space not provisioned” failures with the shared InsufficientStorage error name (from the access package) rather than a routing-specific error name.

Changes:

• Updates /routing/use documentation to reference InsufficientStorage for unprovisioned spaces.
• Removes the routing-specific SpaceNotProvisionedErrorName constant in favor of the shared error naming.

File summaries

File	Description
commands/routing/use.go	Updates docs and exported error-name constants to align unprovisioned-space failures with InsufficientStorage.

Review details

Suppressed comments (1)

commands/routing/use.go:30

• Removing the exported SpaceNotProvisionedErrorName constant is a public API break for downstream users that import commands/routing. Consider keeping it as a deprecated alias that now resolves to the shared InsufficientStorage receipt-failure name, so existing code continues to compile while the protocol error name is unified.

// UnknownPolicyErrorName is the stable receipt-failure name when the
// referenced policy has no stored candidate set. A space with no service
// provider fails with the shared InsufficientStorage name from the access
// package, as every other capability on an unprovisioned space does.
const UnknownPolicyErrorName = "UnknownPolicy"

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The change is a documentation/constant cleanup with no remaining references to the removed error name found in the codebase.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite