Repository navigation
Add AGENTS.md with observability guidance - #24
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude.
Merge after fil-forge/infra-central#253. This PR's
docs/observability.mdpoints to the "Adding an alert or panel" section that PR adds.This adds a short Observability section to
AGENTS.md. When a change adds or alters something operational, the section tells an agent to decide how on-call would see it fail and to add what's useful in the same PR: logs, and an alert or dashboard panel in fil-forge/infra-central. It also says that when a feature's health is best read as a number, the PR description should name the metric and FIL-1152. It also says to skip this for changes nothing operational depends on.The section is kept short because
AGENTS.mdloads into every session. That follows bajtos's review of fil-forge/infra-nodes#174. The how-to lives in a newdocs/observability.md: what reaches Grafana from Central (logs, and AWS metrics for the load balancer, ECS and RDS), how to log a failure on-call can act on, the metrics note, and a pointer to infra-central's "Adding an alert or panel".This PR no longer adds a
CLAUDE.md. Claude Code readsAGENTS.mditself from v2.1.277 (docs).Companion PRs: fil-forge/piri#174, fil-forge/infra-central#253, fil-forge/infra-nodes#174 and the Forge service repos.
Checks
git diff --check.✴️
🤖 Generated with Claude Code
https://claude.ai/code/session_01JCF8gyb8jNRmHmWqQmVhRJ
Generated by Claude Code