Skip to content

Fits produces illegal xml for 25 FPS video #390

Description

@kaylieackerman

FITS produces illegal start elements when the video framerate is 25 fps. For example:

ebucore:start
<ebucore:editUnitNumber editRate="0" factorNumerator="1000" factorDenominator="1001">0</ebucore:editUnitNumber>
</ebucore:start>
ebucore:duration
<ebucore:editUnitNumber editRate="1000" factorNumerator="1" factorDenominator="1">3097360</ebucore:editUnitNumber>
</ebucore:duration>

The editrate attribute is define in the schema as a positiveInteger. An edit rate of 0 is non-sensical and illegal.

Also, it is confusing that the file has its time expressed in two different time-bases since a file can only really have a single timebase for any given video stream. I believe the timebase in the start above of 1000/1001 is incorrect since you don’t see that rate in 25fps video normally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions