fix(core): resolve dependencies and change classes across classloader… - #952
Draft
dieppa wants to merge 1 commit into
Draft
fix(core): resolve dependencies and change classes across classloader…#952dieppa wants to merge 1 commit into
dieppa wants to merge 1 commit into
Conversation
… boundaries Fixes #951. Under Spring Boot DevTools restart, application classes are reloaded through a separate RestartClassLoader while Flamingock's own classes stay on the base loader. Two Class<?> objects with the same fully-qualified name but different defining classloaders are never equal, so Flamingock failed to resolve dependencies and change/param types it had just registered, surfacing as a misleading "Dependency not found" error. - CodeLoadedChangeBuilder: resolve change classes via a classloader fallback chain (thread context classloader, then this class's own loader, then the system loader) instead of relying solely on the implicit default of Class.forName, so it picks up the same "live" app classes the framework is actually using. - SimpleContext: fall back to matching dependencies by fully-qualified class name when exact-type and assignability lookups miss, covering manually registered dependencies split across classloaders. Logs a warning when this fallback is used so a genuine duplicate-class issue on the classpath doesn't get silently masked. - Add ClassloaderMismatchReproTest, simulating the dual-classloader scenario to guard against regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… boundaries
Fixes #951. Under Spring Boot DevTools restart, application classes are reloaded through a separate RestartClassLoader while Flamingock's own classes stay on the base loader. Two Class<?> objects with the same fully-qualified name but different defining classloaders are never equal, so Flamingock failed to resolve dependencies and change/param types it had just registered, surfacing as a misleading "Dependency not found" error.