Fix a bug in the benchmark script and enhance CSV output - #9955
Merged
Conversation
kenzieschmoll
requested review from
johnpryan and
srawlins
and removed request for
a team
August 10, 2026 22:49
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request automates the detection of Flutter and DevTools versions in the performance benchmark script, updates the CSV output format to clearly compare baseline and test metrics, and simplifies query parameter handling for benchmark paths. The review feedback suggests enhancing cross-platform compatibility on Windows by running shell commands with runInShell: true, and refactoring a complex nested ternary operator in the CSV generation logic into a more readable if-else block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
jscompiler was not actually used in the baseline benchmark run