Repository navigation
Conversation
# Conflicts: # .github/workflows/promote-to-prerelease.yml
madhur310
added a commit
that referenced
this pull request
Nov 2, 2026
… - W-24666922 (#8555) Split out of the full W-24666922 migration PR (#8537) as its own minimal, standalone addition. A workflow_dispatch workflow can't be run by filename until it exists on the repo's default branch, even when you intend to run a different branch's content via --ref -- so this exists purely to register the file on develop for dispatch testing. Deliberately omits #8537's automatic release: types: [released] trigger: with Open VSX trusted publishing not yet fully rolled out, this shouldn't fire on the next real stable release before that lands. #8537 supersedes this with the full version once it merges.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publishOpenVSXTrusted.yml— the one top-level workflow both stable and prerelease now use to actually runovsx publish.publishOpenVSX.ymlloses its ownpublishjob (moved to the new file);verify-publishedcan no longerneeds:it (cross-workflow-run dependencies aren't possible), relying instead on its existing poll-loop tolerance.promote-to-prerelease.ymlgains atrigger-openvsx-publishjob that dispatchespublishOpenVSXTrusted.ymlviagh workflow runfor the nightly being promoted.Context
Open VSX's trusted-publisher check matches the OIDC token's
workflow_refclaim — the top-level workflow that initiated the run — notjob_workflow_ref(confirmed againsteclipse-openvsx/openvsx'sGitHubTrustedPublishingProviderSupport.matches()andTrustedPublishingService.registerTrustedPublisher(), which hard-rejects a second trusted-publisher registration per extension, server-side). Stable (publishOpenVSX.yml, fires onrelease: types: [released]) and prerelease (promote-to-prerelease.yml, fires onschedule) were two different top-level files, so no single trusted-publisher registration could ever cover both.publishOpenVSXTrusted.ymlis deliberately not nested viauses:under either existing file: stable triggers it directly via its ownreleaseevent (a sibling ofpublishOpenVSX.yml, not nested inside it — multiple workflow files independently reacting to the same event is normal), andpromote-to-prerelease.ymldispatches it viagh workflow run(a genuinely new, independently initiated run, not auses:call) — so both runs'workflow_refispublishOpenVSXTrusted.ymleither way.It deliberately has no
environment: publish(unlikepublishOpenVSX.yml'sprepare-release-metadata): that environment has arequired_reviewersprotection rule, which would otherwise turn every automated weekly prerelease into one requiring manual approval.vscode-promote-prerelease.yml's own inlineovsxleg is being removed in a parallelgithub-workflowsPR (salesforcecli/github-workflows#199), since Open VSX publishing for prerelease now happens via this dispatch instead.Two
uses:refs in this PR are temporarily pinned to thegithub-workflowsPR branch (salesforcecli/github-workflows@ms/W-24666922-ovsx-trusted-publishing) instead of@main, to validate end-to-end before that PR merges — markedTEMPORARYin both files. Must switch back to@mainbefore this PR merges, coordinated with that PR's merge.Validation
actionlinton all three files: zero new findings vs.develop(same pre-existing shellcheck notices only).publishOpenVSXTrusted.ymldirectly (pinned to thegithub-workflowstest branch) against an already-published,--skip-duplicate-safe nightly tag, covering all 17 Open VSX-published extensions in this repo — no new content reached the registry. Run 41499926285 / publish job:🔐 Trusted publishing token issued for ...logged for every extension, zero❌ No trusted publisher matcheserrors.publishOpenVSXTrusted.yml(via the registration-only#8555, merged, to get the workflow name ontodevelopfirst).Test plan
promote-to-prerelease.ymland confirmtrigger-openvsx-publishis skipped underdry-run: truepublishOpenVSXTrusted.ymlagainst an existing nightly tag; confirmed real (non-dry-run) run against an already-published,--skip-duplicate-safe tag succeeds with no new content published — see Validation aboveuses:refs back to@mainonce fix(release): migrate Open VSX publishing to OIDC trusted publishing - W-24666922 salesforcecli/github-workflows#199 mergespublishOpenVSXTrusted.yml@W-24666922@
Manual test plan
Nothing worth manually testing.