Conversation
…o-2³² wraparound without invoking signed-overflow undefined behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an interesting issue where compiling with GCC at -O2 and -O3 made modem training unstable but compiling the receiver at -O0, or with -fwrapv, made it work. Eventually tracked it down to this.
The phase angles represent a full turn in 32 bits, so the differences need to wrap around. For example, going from 0x7ffffff0 to 0x80000010 should give a difference of 32, but subtracting those as signed integers overflows. Casting the result to unsigned afterward is too late.
This moves the casts before the arithmetic so the wraparound is defined, then casts back to signed where the training logic expects it.