Repository navigation
Replace Axios with fetch outside MeSH provider - #798
Open
floze-the-genius wants to merge 1 commit into
Open
floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
Member
|
Thanks for your contribution. This first needs to be tested by hand in a live instance of Cocoda application, in particular because HTTP calls from browser are slightly different then HTTP calls from NodeJS. We also plan to remove axios in dependency cocoda-sdk, to a thin class HTTPClient is favoured over utility function |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchJsonhelper that preserves non-2xx error handlingAbortControllersignals passed throughcocoda-sdkRefs #787.
The custom MeSH provider is intentionally unchanged because its move/removal is tracked separately by #786.
Validation
npm run lint(passes with the two existing component-name warnings insrc/main.js)npm run buildfetchJsoncocoda-sdkpropagates theAbortSignaland cancels the requestImplementation and validation were assisted by Codex.