Repository navigation
refactor(interaction): move request lifecycle out of TUI - #694
Merged
san-ci[bot] merged 3 commits intoOct 30, 2026
Merged
Conversation
|
[REVIEW NOTIFIER] This PR requires a review from @zhujian7. Once this PR has been reviewed and has the |
|
[REVIEW NOTIFIER] This PR requires a review from @zhujian7. Once this PR has been reviewed and has the |
yanmxa
force-pushed
the
refactor/conversation-lifecycle
branch
from
October 29, 2026 13:56
cdf0b11 to
5eee6c1
Compare
Member
Author
|
Regression validation completed on the renamed interaction package:
|
Contributor
|
/lgtm |
Signed-off-by: Meng Yan <yanmxa@gmail.com>
Signed-off-by: Meng Yan <yanmxa@gmail.com>
Signed-off-by: Meng Yan <yanmxa@gmail.com>
san-ci
Bot
force-pushed
the
refactor/conversation-lifecycle
branch
from
October 30, 2026 02:01
1c06482 to
458728a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Extract approval, question and secret-input request lifecycle from the TUI into
internal/interaction, allowing a future ACP adapter to reuse it.Responsibilities
interaction(new)app(existing)agent.Runtime(unchanged)The new package is named
interaction, notconversation: it manages requests awaiting an external response, not whole conversations.API
Request.Valid(owner)/Cancel(): validate lifetime and ownership; send a nonblocking cancellation reply.Queue.Enqueue(request, owner)/Pop(): validate and queue requests; retrieve them in FIFO order.Queue.Prune(owner)/Cancel(): remove invalid requests or cancel all queued requests.The queue is single-owner and starts no goroutines. The TUI retains and validates the active request. Foreground cancellation does not cancel independent background requests with live contexts.
Scope and validation
upstream/mainat47479b97(feat(agent): simplify delegation and continue sessions through SendMessage #692).go test ./..., interaction/TUI race tests, layercheck andmake lintpassed.