openapi3filter: regression test for empty query param with default - #1254
Closed
AliaksandrKhalupka wants to merge 3 commits into
Closed
AliaksandrKhalupka wants to merge 3 commits into
AliaksandrKhalupka wants to merge 3 commits into
Conversation
Document expected behaviour with XXX not yet fixed, matching issue733_test.go. When fixed, uncomment the expected assertion and remove the current one. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Closing in favor of #1274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue ...
Adds a regression test for optional query parameters sent with an empty value when the schema defines a default.
Repro:
GET /test?flag=withtype: boolean,default: falseExpected (commented in test):
req.URL.Query()["flag"]is["false"]Current behaviour (asserted until fixed):
["", "false"]— default injection usesq.Addwithout removing the existing empty value.