Skip to content

enketo-secrets: tidy up files - #2303

Merged
alxndrsn merged 4 commits into
getodk:nextfrom
alxndrsn:rename-secrets-dockerfile
Nov 5, 2026
Merged

alxndrsn merged 4 commits into
getodk:nextfrom
alxndrsn:rename-secrets-dockerfile

Conversation

@alxndrsn

@alxndrsn alxndrsn commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Work on postgres & postgres14 container updates uncovered confusion in the purpose and depenendents of the secrets container.

  1. rename dockerfile from secrets.dockerfile to enketo-secrets.dockerfile
  2. move container-specific files to their own directory

Reduce ambiguity around the purpose of the secrets service.

The service itself and the associated shared volume are not renamed, as these changes would introduce complications to existing environments.

What has been done to verify that this works as intended?

  • ci

Why is this the best possible solution? Were any other approaches considered?

Alternatives:

  • leave as-is
  • rename volume from secrets -> enketo-secrets
  • rename service from secrets -> enketo-secrets

How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?

There may be merge conflicts for any users who have modified either of:

  • secrets.dockerfile
  • files/enketo/generate-secrets.sh

It seems unlikely that these files would have been modified.

Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.

  • update changelog

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No - there are no existing mentions in docs to either the generate-secrets.sh script or the service's dockerfile.

1. rename dockerfile from `secrets.dockerfile` to `enketo-secrets.dockerfile`
2. move container-specific files to their own directory

This change follows up dd78c4d to reduce ambiguity around the purpose of the `secrets` service.

The service itself and the associated shared volume are not renamed, as these changes would introduce complications to existing environments.
@alxndrsn
alxndrsn changed the base branch from master to next November 2, 2026 06:42
@alxndrsn alxndrsn changed the title Rename secrets dockerfile enketo-secrets: tidy up files Nov 2, 2026
@alxndrsn
alxndrsn marked this pull request as ready for review November 2, 2026 06:45
@alxndrsn
alxndrsn merged commit 1dcc94d into getodk:next Nov 5, 2026
7 checks passed
@alxndrsn
alxndrsn deleted the rename-secrets-dockerfile branch November 5, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants