Skip to content

Revert "docker-compose: remove "service" dependency on "secrets" - #2305

Merged
garethbowen merged 1 commit into
getodk:nextfrom
alxndrsn:revert-secrets-deps
Nov 3, 2026
Merged

garethbowen merged 1 commit into
getodk:nextfrom
alxndrsn:revert-secrets-deps

Conversation

@alxndrsn

@alxndrsn alxndrsn commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This reverts commit dd78c4d (#2302).

While the secrets service is indeed the Enketo secrets, the service container requires access to the enketo API key, which is stored there.

What has been done to verify that this works as intended?

Tested in frontend CI e2e tests.

Why is this the best possible solution? Were any other approaches considered?

#2302 was incorrect. Reverting it completely is the simplest approach to fixing CI.

How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?

No effect - reverts a regression.

Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

…odk#2302)"

This reverts commit dd78c4d.

While the `secrets` service is indeed the Enketo secrets, the `service` container requires access to the enketo API key, which is stored there.
@alxndrsn
alxndrsn marked this pull request as ready for review November 3, 2026 07:13
@alxndrsn
alxndrsn requested a review from garethbowen November 3, 2026 07:13

@garethbowen garethbowen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garethbowen
garethbowen merged commit eda7d65 into getodk:next Nov 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants