Repository navigation
service/start-odk: check memtot in bytes - #2306
Merged
Merged
Conversation
added 2 commits
November 3, 2026 14:04
All `memtot` values are fetched in bytes, but the final comparison was previously expecting kilo/kibibytes. Closes getodk#2169
alxndrsn
marked this pull request as ready for review
November 3, 2026 14:22
lognaturel
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
memtotvalues are fetched in bytes, but the final comparison was previously expecting kilo/kibibytes.Closes #2169
What has been done to verify that this works as intended?
Lots of discussion on #2169
Why is this the best possible solution? Were any other approaches considered?
An alternative would be to convert all values back to kB, and compare that. But it seems riskier, as there will be more changes to cgroup1 & cgroup2 code, and I don't have envs to recreate those.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Unlikely to impact users - should only affect users who have less than 1GB RAM, and 1GB is stated as minimum, 2GB recommended per:
Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.