Skip to content

service/start-odk: check memtot in bytes - #2306

Merged
alxndrsn merged 3 commits into
getodk:nextfrom
alxndrsn:memtotal
Nov 5, 2026
Merged

alxndrsn merged 3 commits into
getodk:nextfrom
alxndrsn:memtotal

Conversation

@alxndrsn

@alxndrsn alxndrsn commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

All memtot values are fetched in bytes, but the final comparison was previously expecting kilo/kibibytes.

Closes #2169

What has been done to verify that this works as intended?

Lots of discussion on #2169

Why is this the best possible solution? Were any other approaches considered?

An alternative would be to convert all values back to kB, and compare that. But it seems riskier, as there will be more changes to cgroup1 & cgroup2 code, and I don't have envs to recreate those.

How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?

Unlikely to impact users - should only affect users who have less than 1GB RAM, and 1GB is stated as minimum, 2GB recommended per:

Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.

  • update changelog

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

alxndrsn added 2 commits November 3, 2026 14:04
All `memtot` values are fetched in bytes, but the final comparison was previously expecting kilo/kibibytes.

Closes getodk#2169
@alxndrsn
alxndrsn marked this pull request as ready for review November 3, 2026 14:22
@alxndrsn
alxndrsn merged commit 35c5bfd into getodk:next Nov 5, 2026
7 checks passed
@alxndrsn
alxndrsn deleted the memtotal branch November 5, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants