Repository navigation
form-wrapper: allow any frame-ancestor - #2321
Merged
Merged
Conversation
Member
|
I think we can use the presence of the The query param needs to have a value to have any chance of being a valid Public Access Link so it's fine and good for a URL with only |
added 10 commits
November 10, 2026 07:22
alxndrsn
marked this pull request as ready for review
November 12, 2026 15:38
lognaturel
approved these changes
Nov 13, 2026
lognaturel
left a comment
Member
There was a problem hiding this comment.
Quick wording change please! There's a chance I flagged that I can't convince myself is necessary but I also don't think it's problematic.
| location / { | ||
| root /usr/share/nginx/html; | ||
| try_files $uri $uri/ $spa_html; | ||
| try_files $uri $uri/ "$spa_html$is_args$args"; |
Member
There was a problem hiding this comment.
Is this the fix for Enketo forms not working currently? Is it for sure needed? I thought this was the default nginx behavior!
Contributor
Author
There was a problem hiding this comment.
It's needed, otherwise $arg_st is empty when re-evaluated after the uri rewrite.
- without this change: ❌ https://github.com/getodk/central/actions/runs/43381398671
- with this change: ✅ https://github.com/getodk/central/actions/runs/43382253001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2314
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Detection of single-use forms is tricky, but checking for the
stquery param is deemed good-enough here.How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Should only relax embedding rules, so low risk of breaking anything.
Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.