Repository navigation
feat(web-forms#517): add variable for Google Maps API key - #2326
Merged
Merged
Conversation
latin-panda
marked this pull request as ready for review
November 13, 2026 22:01
Contributor
Author
|
@matthew-white, could you please review this PR when you get a chance? |
matthew-white
approved these changes
Nov 16, 2026
matthew-white
left a comment
Member
There was a problem hiding this comment.
Looks good, the approach makes sense to me!
…gle-maps-settings-wf # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Branch off and target
next, notmaster. Themasteris stable and used in production (exception: documentation/infrastructure-only changes).Closes getodk/web-forms#517
WF PR: getodk/central-frontend#1993
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
The frontend already reads /client-config.json for sentryDsn, so adding one field is the smallest change. Passing the key through the backend or the form definition was considered by the team, and we decided to go with the smallest solution for now, since it's not form data, and the backend does not need it.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
The variable is optional and defaults to empty, so existing deployments keep OpenStreetMap.
Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.
I added the entry to the CHANGELOG.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes, WIP here: getodk/docs#2128